From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from omta36.uswest2.a.cloudfilter.net (omta36.uswest2.a.cloudfilter.net [35.89.44.35]) by sourceware.org (Postfix) with ESMTPS id EF76A385829C for ; Thu, 14 Mar 2024 12:29:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org EF76A385829C Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org EF76A385829C Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=35.89.44.35 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710419370; cv=none; b=ii1kWwuZ0WxmtPE5znOG+ZBzQpHMR1Xik9G6CBI3COOqmqy/ImYd0ogZEUa1TXKXNThMJJsyNiuWv5iDDoPsb/wJJwa5RHyyV5lH3IfEGI43qjHiRc6Cc0IdYRbV8xAUjPi4mUBHH/214mOQBSLUMRLYFZb5WZcwieGJr3s7mtI= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710419370; c=relaxed/simple; bh=b6QFViclgREVIJNC8On7xb0tA3M0t60/plUHwceBJKM=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=re5WwdrFUqKNirptsasEYi1mCw7fdaQJlj74R2tzx/4m5JzUnHgGnI4sKje7SpmbnwSfJtXQW/f87vQgHuXU0Qj+w5rAThbUqsmiEx5Lmpi/zjwcwwEAe6VMJUvWFNW/khJmSteBULmVWnIBkYXnWcR73oHyHbxJefYuRhbmlb4= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from eig-obgw-6003a.ext.cloudfilter.net ([10.0.30.151]) by cmsmtp with ESMTPS id kjCXr39iNtf2QkkD8rl7iT; Thu, 14 Mar 2024 12:29:26 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id kkD8rX37h0ulnkkD8rTb2J; Thu, 14 Mar 2024 12:29:26 +0000 X-Authority-Analysis: v=2.4 cv=XY6Pzp55 c=1 sm=1 tr=0 ts=65f2eda6 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=K6JAEmCyrfEA:10 a=Qbun_eYptAEA:10 a=20KFwNOVAAAA:8 a=q6dzBOp83qvx3A3Y5pkA:9 a=PnE7dl4cG_QA:10 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=a58lhPItWx6tbI5tJollOPDXnvbPeYtZZ+mWalVY818=; b=bo6/xWxIHYQZfUqt3sBZO7J8Kp DcNGFFeCRR1gZLSD6SJtqGUurvN5TCWiH1vrArthdlKacnYugTlNup+wRLKm3pc93vonRnoTyBd8x /Wqufceu8qzYqjhKdlPRXgMd1; Received: from 97-122-82-115.hlrn.qwest.net ([97.122.82.115]:33258 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96.2) (envelope-from ) id 1rkkD7-002QfS-2Q; Thu, 14 Mar 2024 06:29:25 -0600 From: Tom Tromey To: Aaron Merey Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] gdb/dwarf2: Check for missing abbrev References: <20240313201827.1853989-1-amerey@redhat.com> X-Attribution: Tom Date: Thu, 14 Mar 2024 06:29:24 -0600 In-Reply-To: <20240313201827.1853989-1-amerey@redhat.com> (Aaron Merey's message of "Wed, 13 Mar 2024 16:18:27 -0400") Message-ID: <87cyrxm1y3.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.82.115 X-Source-L: No X-Exim-ID: 1rkkD7-002QfS-2Q X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-82-115.hlrn.qwest.net (murgatroyd) [97.122.82.115]:33258 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfLq42HpVYOBHiV12Bmb3AK0laEpUTkVaCOm5dFOykch6e5TEF13Op9UG2GxEvB1hf6yP2LEZ6hO43ZT/l3yrczSgLO65Q9S9zflq3dCrx8O0C02vPJZO ++vcJeypxHKQjYJUuovZJT1J8WS47z224El+3ytP7/Tf1fAmEzN1OPffJ0c7ShEcRljNHLu/+LjyYtHDu3r9+P2kiOysDNb6qEw= X-Spam-Status: No, score=-3015.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Aaron" == Aaron Merey writes: Aaron> + if (abbrev == nullptr) Aaron> + throw_error (NOT_AVAILABLE_ERROR, _("Unable to find DWARF attributes.")); NOT_AVAILABLE_ERROR is specific to unavailable values. This should just use error() Tom