From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-il1-x12c.google.com (mail-il1-x12c.google.com [IPv6:2607:f8b0:4864:20::12c]) by sourceware.org (Postfix) with ESMTPS id 450EA384CB97 for ; Thu, 15 Feb 2024 17:11:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 450EA384CB97 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 450EA384CB97 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::12c ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1708017088; cv=none; b=JLXBPvG6iehR3j4nB9eYb24YzombmZBQ7jsYCVUb8dh4feNbd7CULUOk71zbxZ7LSbVFj2uGpM5PuD1KS/HQGyF/6zjczWRtpUH2FJNGUDMMhmO9NKgciXGSD5o0hk6qEYaRE2nIuS90N89+2K0JpVoAlMKYE6UIh/ibKE/emPg= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1708017088; c=relaxed/simple; bh=ep5iVWM5/lH9ybf/tEzVp7wtpk7DCHq3xGu2zB+sZtE=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=sJn26dvMEJ2nHdbo11zE8BtFBmC6xH8ORLagBprvuW1EP/6I9xCgsX47/dn9jt7XjS78eErcOHETHKu5TXefqOvwTs+65Da1ZoDmxf22EGXxSAdPZzF33+nak9pfp7dwaqrQBvLdfvbuElO4Ntssl13ycjZmR54tonWpaEbQWjI= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-il1-x12c.google.com with SMTP id e9e14a558f8ab-363dde86f0bso3123545ab.3 for ; Thu, 15 Feb 2024 09:11:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1708017083; x=1708621883; darn=sourceware.org; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=4gT/sPkEWu0V28KV1H/QZx7gx6RD8rO1RlYum7GuQVg=; b=XwgfJ6t/DvKMH1Q8htUL0wpFKipZHmn4t+gJdA0YSXofS3XRZuyHRehBBKSVqw3FlI TAjDQBgCaLFWs2BmsX5rZTybh2YLBlvwXPG4cRkg+rVO0p+6y2vSPLL/kmOVxJGtUx0U ktvXphgv6rJDxjORNoRcg3OOk+WzwglG9MwrfYfZCSQzRO5r4IU/oCWYCBK3lOCCG7km In1rn4Xz/5DnWkMj4tDzu2QwboTdaM+BxeP6LfE8wia9cqiDUsX4e8pojx/a7wR9gRrj mWTwncebYrTsDKAdcffH+Egh/fvPO9WEkkUEow6nTEPnWKMvWRExGLFZ0gTKnsVzlwcg 1VsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708017083; x=1708621883; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=4gT/sPkEWu0V28KV1H/QZx7gx6RD8rO1RlYum7GuQVg=; b=BuUO0aihImxj3AP4sCLn4DwoZkL0SgfsOneOjTVI8/w0QIwBf+WRW6xkv4XMT3StjH 0Taapb/T1MblN5Rf+lb39zDYUaABaO6lKS3GMjxWAyIjdf1r9bzZ3DfYzLqCh8uwajW5 L/CDYcQ3i4edbM1L5ooV80nFYCNhzVfzmKHhOaqZLBGlen6M+1C3gtFcbG/7LMu5mPVC sMGChsT6Hmggtlk9xa3qAT291KIfgNgwOCvZJ8Aa6jncTt+bLs6562dOSScLlT3YHNOh 04u7WxVh1k1GMnHEY1NWFx7ztZ2RHxzsdsK89K3m58fF6IDudG/TZVqHfzCNIyXbWTz7 KTLA== X-Gm-Message-State: AOJu0YzFm71K2dAkLPeCf8zR3FqgySkBLxzAmYzv2RwwHS4hYbkTpuBY DOuWiNYTLy86Lajl3yz0ZALAFsTYkFgy1Sczpjv4Gb20KavAMvfWb5Myu0AH1ZVE73n4u7XaLYE = X-Google-Smtp-Source: AGHT+IGp+nuGYfmm0fyepkOBjAUXX0SXJl+8cxSNd2Co6EI46XlmZNHGvqc0dxplRHWhFZxM9PBMYw== X-Received: by 2002:a92:d2cb:0:b0:363:c041:154d with SMTP id w11-20020a92d2cb000000b00363c041154dmr2219369ilg.16.1708017083465; Thu, 15 Feb 2024 09:11:23 -0800 (PST) Received: from murgatroyd (71-211-170-195.hlrn.qwest.net. [71.211.170.195]) by smtp.gmail.com with ESMTPSA id p2-20020a056e02104200b00364187af517sm468602ilj.80.2024.02.15.09.11.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Feb 2024 09:11:23 -0800 (PST) From: Tom Tromey To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] Move lookup_name_info creation into basic_lookup_transparent_type References: <20240125181929.5811-1-tromey@adacore.com> X-Attribution: Tom Date: Thu, 15 Feb 2024 10:11:22 -0700 In-Reply-To: <20240125181929.5811-1-tromey@adacore.com> (Tom Tromey's message of "Thu, 25 Jan 2024 11:19:29 -0700") Message-ID: <87cysx4pqd.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-5.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Tom" == Tom Tromey writes: Tom> I noticed that basic_lookup_transparent_type calls two different Tom> functions that both proceed to create a lookup_name_info. It's more Tom> efficient to create this object in the outermost layer possible. Tom> Making this change required a few related changes, resulting in this Tom> patch. Tom> There are still more changs of this sort that could be made. Tom> Regression tested on x86-64 Fedora 38. I'm checking this in. Tom