Re: [PATCH 1/4] gdb/unittests: add extract_string_maybe_quoted self tests

[Tom Tromey <tom@tromey.com>]

>>>>> "Andrew" == Andrew Burgess <aburgess@redhat.com> writes:

Andrew> This commit adds some self tests for the extract_string_maybe_quoted
Andrew> function.  No functionality is changed in this commit.

Andrew> +  test_def (const char *input,
Andrew> +	    const char *output,
Andrew> +	    size_t offset)
Andrew> +    : m_input (input),
Andrew> +      m_output (output),
Andrew> +      m_offset (offset)
Andrew> +  { /* Nothing.  */ }

I wonder -- if this constructor was constexpr, would that create the
objects in the rodata section?

I don't really know how that works.  However, making data read-only like
this is one of the advantages of...

Andrew> +test_def tests[] = {
Andrew> +  { "abc def", "abc", 3 },

... making this kind of thing 'static const'.

Tom