From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 1929C3857B8A for ; Fri, 2 Feb 2024 15:46:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1929C3857B8A Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 1929C3857B8A Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706888788; cv=none; b=Cq9jIm4x7B1m7RXcUPgb2xTfgpX0EauUaKXnSMD6mecITzVHrfbPpD4PFLKNrzyi+rMD0NN9iMGrIbqdF9qtcjHTJkz3Clh1DOgZmSHdBui8p6tw65eV8uirQGFHWhIrzDBX9f+hF6dn+BDlPwai20ISqIQb5FP/Lbco569pn3I= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706888788; c=relaxed/simple; bh=TPWMjINS34YYGL6XhJiQLN7sAlr6d6pFN4wRoK0+UXU=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=h7pS1tPz0FpDEoovdZI+hfSNqsXcRsdbrQce0GUVRRHfXUlTNWPmd0IbAMnYuEPtL6vsIfKVJXaC7PgK4NvO1PDcdpWtQseIVUDfwSBUfdtOqiiQLIyusooCUeA+PtbWyXgEt4ZRIQPocTf89PDN9l436zlXmz7BDfJ1u4s50Hw= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1706888786; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=hd52f1r58r3mQ5C0BmGUb9HQGnxvnBDE8tuHwh29JYk=; b=eJoi0lGVn3q2BWPXZ9l3mL9srETCT9HAIFWOOTamzpi8RoqlyhuHx0zyAmS/pSJxx2NMeN JQphH9fIVqifOCnpq1FwtyArhPrASAYWdiRU0UjC1+li/mKspQGr2H5I6+2QjCAKt6zf3P 4zE/U9cLtUyotlDGlKA5h/kmivmdHS0= Received: from mail-lf1-f72.google.com (mail-lf1-f72.google.com [209.85.167.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-201-GoBNSNQRPLCWM6_lymOlUQ-1; Fri, 02 Feb 2024 10:46:25 -0500 X-MC-Unique: GoBNSNQRPLCWM6_lymOlUQ-1 Received: by mail-lf1-f72.google.com with SMTP id 2adb3069b0e04-5100d033f56so1816001e87.0 for ; Fri, 02 Feb 2024 07:46:25 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706888783; x=1707493583; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=hd52f1r58r3mQ5C0BmGUb9HQGnxvnBDE8tuHwh29JYk=; b=b0dUW6LzCpEuH+xofSXu9qchBj831wu3rGTJ+DU7tcwIdPW6gyQN6eiFMxjkD9JPyR nVT3yJf1ZmCHXLisxC22WCHPgLMpURWEw1zzocpFhCxe7R5ZcrqNvAMOSqe3+tGOu79R zXxK+UqUr2flNbEzUTt3VFFSNW/4tO9qvcnSWSFp5cJARDzlv9AVXRTTgKWRPjffNYDL xARHoSIM786pw34jcMFAvSLgRxhearSUb5NaKmbjD9pMtBU9QCEc1wn5YZYX7mOcEh0r tTLRbuiTyWRGqs+zbEsbR2YbOHTWOL0xRkgJxfv0FZwYTIXgW3QI4fY9vXdmO3oKkw0m XLQw== X-Gm-Message-State: AOJu0YwnlM7WBPnOvN3H3jm4pn2Pg9x7fmFOs4YbuqsFaVmWizyJbQok KR1H9UiQ6N1sxrkcq2ZRF/xa9UF8PyamGtlbpfkOOGi7bzB5yWi2sw1/xL/ggB215x1ezgsKgAJ 3oGRXpFg46MNN2RbZayTt74pAOfWdpeddyxE3zwEIh3HZaNE7mu76QwVbanBALkx1u4E= X-Received: by 2002:a05:6512:5d6:b0:50e:3649:8649 with SMTP id o22-20020a05651205d600b0050e36498649mr3864568lfo.61.1706888783299; Fri, 02 Feb 2024 07:46:23 -0800 (PST) X-Google-Smtp-Source: AGHT+IHUzw+HhWGxa12fWLfuBKG1WEinR4hS34A5LHOd9WIbwpHHB3XIaba8wLslMt7uxeQLJsErtg== X-Received: by 2002:a05:6512:5d6:b0:50e:3649:8649 with SMTP id o22-20020a05651205d600b0050e36498649mr3864552lfo.61.1706888782872; Fri, 02 Feb 2024 07:46:22 -0800 (PST) Received: from localhost (185.223.159.143.dyn.plus.net. [143.159.223.185]) by smtp.gmail.com with ESMTPSA id az25-20020a05600c601900b0040ef95e1c78sm276020wmb.3.2024.02.02.07.46.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Feb 2024 07:46:22 -0800 (PST) From: Andrew Burgess To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] gdb: attach to a process when the executable has been deleted In-Reply-To: <87cytkgep8.fsf@tromey.com> References: <87cytkgep8.fsf@tromey.com> Date: Fri, 02 Feb 2024 15:46:21 +0000 Message-ID: <87cyteyilu.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-7.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Tom Tromey writes: >>>>>> "Andrew" == Andrew Burgess writes: > > Andrew> Bug PR gdb/28313 describes attaching to a process when the executable > Andrew> has been deleted. The bug is for S390 and describes how a user sees a > Andrew> message 'PC not saved'. > ... > Andrew> I propose that we add an `access` call to linux_proc_pid_to_exec_file > Andrew> to check that the target file exists and can be read. If the target > Andrew> can't be read then we should fall back to /proc/PID/exe (assuming that > Andrew> /proc/PID/exe can be read). > > Thank you. This makes sense to me. > Approved-By: Tom Tromey Pushed. Thanks, Andrew