From: Tom Tromey <tom@tromey.com>
To: Andrew Burgess <aburgess@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] gdb: attach to a process when the executable has been deleted
Date: Mon, 29 Jan 2024 11:46:43 -0700 [thread overview]
Message-ID: <87cytkgep8.fsf@tromey.com> (raw)
In-Reply-To: <bec0cf4bc33a57a6efe71359b09b79cd3862562b.1706391397.git.aburgess@redhat.com> (Andrew Burgess's message of "Sat, 27 Jan 2024 21:37:01 +0000")
>>>>> "Andrew" == Andrew Burgess <aburgess@redhat.com> writes:
Andrew> Bug PR gdb/28313 describes attaching to a process when the executable
Andrew> has been deleted. The bug is for S390 and describes how a user sees a
Andrew> message 'PC not saved'.
...
Andrew> I propose that we add an `access` call to linux_proc_pid_to_exec_file
Andrew> to check that the target file exists and can be read. If the target
Andrew> can't be read then we should fall back to /proc/PID/exe (assuming that
Andrew> /proc/PID/exe can be read).
Thank you. This makes sense to me.
Approved-By: Tom Tromey <tom@tromey.com>
Tom
next prev parent reply other threads:[~2024-01-29 18:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-27 21:37 Andrew Burgess
2024-01-29 18:46 ` Tom Tromey [this message]
2024-02-02 15:46 ` Andrew Burgess
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87cytkgep8.fsf@tromey.com \
--to=tom@tromey.com \
--cc=aburgess@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).