From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from omta34.uswest2.a.cloudfilter.net (omta34.uswest2.a.cloudfilter.net [35.89.44.33]) by sourceware.org (Postfix) with ESMTPS id B50783858D32 for ; Sat, 25 Nov 2023 03:42:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B50783858D32 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org B50783858D32 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=35.89.44.33 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700883772; cv=none; b=ufxchJMDwP6S/DmimbtLPU9/tGndJBMyNX6rsYuKYSjPb2rfY5jXd+hUlKXFLtTHmPLCxRNfWy49gi8TI0C/i3dvhXIsSJwerOsI6NBQp+vjuLlBl4SfxHW6wlUUBNmGpTxFDWL3z3KeSYytbiVooCKCDGDwby2LeBqWGoHUjJY= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700883772; c=relaxed/simple; bh=KYhfJDTACZD2R2pwbgRfrvs6Xu2IBVhNDzrnv234S+8=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=YpLy/fSQSk5l9coCGiklzBvA+dlxlKKadswHn7Ymkjm2SulOycynmCeg+Xu+04JgI06ITWKkCe+uYfraSetAaK4l6jokE+WpsyXVLgM4kaHl+jLJVlZwrPAPXH7rs2QKwm6Kg2c+Wuz997LsIr1+g0XeWFX6YQzixFwhFNhOHo8= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from eig-obgw-5005a.ext.cloudfilter.net ([10.0.29.234]) by cmsmtp with ESMTPS id 6iQarpGfu8Hte6jZCrvprW; Sat, 25 Nov 2023 03:42:51 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id 6jZBrKDYb1b9N6jZCrJBmU; Sat, 25 Nov 2023 03:42:50 +0000 X-Authority-Analysis: v=2.4 cv=FLYIesks c=1 sm=1 tr=0 ts=65616d3a a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=OWjo9vPv0XrRhIrVQ50Ab3nP57M=:19 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=BNY50KLci1gA:10 a=Qbun_eYptAEA:10 a=yLHZFLJQ5jjnTjWe9FEA:9 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=/NyrIQngJATD4nYfCr1t9ylmrffOsY+8Y3dhDZp7lVk=; b=MN6U+vnNs4dAwRPMgc2gFQNbIb 0ReTjj54UrYLtl5VjnUTVv1Z30I4iyrknJpTBSvjhhUn3tCZAH2tzAWnT6MrJIK2yTj8YrsBUUuXE J6Uu7FYt4+qPjyx5NLqNsseOA; Received: from 97-122-77-73.hlrn.qwest.net ([97.122.77.73]:50786 helo=prentzel) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96.2) (envelope-from ) id 1r6jZB-002p1L-0z; Fri, 24 Nov 2023 20:42:49 -0700 From: Tom Tromey To: Tom de Vries Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] [gdb/tui] Fix displaying main after resizing References: <20231124085902.24318-1-tdevries@suse.de> X-Attribution: Tom Date: Fri, 24 Nov 2023 20:43:02 -0700 In-Reply-To: <20231124085902.24318-1-tdevries@suse.de> (Tom de Vries's message of "Fri, 24 Nov 2023 09:59:02 +0100") Message-ID: <87cyvyxzuh.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.77.73 X-Source-L: No X-Exim-ID: 1r6jZB-002p1L-0z X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-77-73.hlrn.qwest.net (prentzel) [97.122.77.73]:50786 X-Source-Auth: tom+tromey.com X-Email-Count: 4 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfMYJrjhLOmhFrb/kJwHVGEjfbucBU3VPXKo0RuoXd0ciYWYoO8+qnv1tw6ItaNSOzH0nbCrrX0yq3U4lQxncQReiiHqwxf8GLFrE79P+VVrX6t09hive BTt/wfn+Cn5t+thW1psAk7inqMJfrdVBVcBO0xHbLANY/FVZU5eUS3rDGaQ1Djj22IoRh7jwYE3msZ8IcpUUk+HyJAweKPm1Ap8= X-Spam-Status: No, score=-3017.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Tom" == Tom de Vries writes: Tom> Fix this by moving a call to tui_display_main from tui_enable to Tom> tui_apply_current_layout. Tom> - tui_update_source_windows_with_addr (gdbarch, addr); Tom> + if (addr == 0) Tom> + tui_display_main (); Tom> + else Tom> + tui_update_source_windows_with_addr (gdbarch, addr); This 'if' seems like something the source window ought to know, not the layout code. But between this and the register window patch in the same spot, I wonder if there's some more generic solution available. Like, if I write a TUI window in Python, will redoing the layout cause a refresh? If not -- isn't that a bug? Or if so -- why can't built-in windows work the same way? Tom