From: Tom Tromey <tromey@adacore.com>
To: Lancelot SIX <lsix@lancelotsix.com>
Cc: Tom Tromey <tromey@adacore.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH 3/7] Remove byte vectors from cplus_struct_type
Date: Fri, 27 Oct 2023 08:20:56 -0600 [thread overview]
Message-ID: <87cyx0m9iv.fsf@tromey.com> (raw)
In-Reply-To: <20230925223241.phor5lusw7jd4flf@octopus> (Lancelot SIX's message of "Mon, 25 Sep 2023 23:32:41 +0100")
>>>>> "Lancelot" == Lancelot SIX <lsix@lancelotsix.com> writes:
>> + /* Whether the field is 'private'. */
>> + bool m_private : 1;
>> + /* Whether the field is 'protected'. */
>> + bool m_protected : 1;
Lancelot> Is there a reason I miss to not use an enum to describe the visibility?
Lancelot> This would avoid having to verify that m_private and m_protected are
Lancelot> mutually exclusive.
I changed this in v2.
>> case VISIBILITY_PROTECTED:
>> + newobj->field.set_private ();
Lancelot> I think this should be:
newobj-> field.set_protected ();
I fixed this too.
Tom
next prev parent reply other threads:[~2023-10-27 14:20 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-21 18:01 [PATCH 0/7] Remove char-based bitfield macros Tom Tromey
2023-09-21 18:01 ` [PATCH 1/7] Use .def file to stringify type codes Tom Tromey
2023-09-25 21:58 ` Lancelot SIX
2023-09-26 13:10 ` Tom Tromey
2023-09-21 18:01 ` [PATCH 2/7] Print field accessibility inline Tom Tromey
2023-09-21 18:01 ` [PATCH 3/7] Remove byte vectors from cplus_struct_type Tom Tromey
2023-09-25 22:32 ` Lancelot SIX
2023-10-27 14:20 ` Tom Tromey [this message]
2023-09-21 18:01 ` [PATCH 4/7] Add field::is_public Tom Tromey
2023-09-21 18:01 ` [PATCH 5/7] Remove some QUIT calls from need_access_label_p Tom Tromey
2023-09-21 18:01 ` [PATCH 6/7] Remove some type field accessor macros Tom Tromey
2023-09-21 18:01 ` [PATCH 7/7] Remove char-based bitfield macros Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87cyx0m9iv.fsf@tromey.com \
--to=tromey@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=lsix@lancelotsix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).