Re: [PATCH] gdb/configure.ac: Add option --with-additional-debug-dirs

[Thiago Jung Bauermann <thiago.bauermann@linaro.org>]

Hello Tom,

Thank you for your review!

Tom Tromey <tom@tromey.com> writes:

>>>>>> "Thiago" == Thiago Jung Bauermann via Gdb-patches <gdb-patches@sourceware.org>
> writes:
>
> Thiago> If you want to install GDB in a custom prefix, have it look for debug info
> Thiago> in that prefix but also in the distro's default location (typically,
> Thiago> /usr/lib/debug) and run the GDB testsuite before doing "make install", you
> Thiago> have a bit of a problem:
>
> ...
> Thiago> I thought it was simpler to add a new option to specify a list of
> Thiago> additional directories that will be appended to the debug-file-directory
> Thiago> setting.
>
> I don't think this was ever reviewed?  Sorry about that.

It wasn't. Not a big deal though. I've been applying the patch locally
in our CI in the meantime.

> Thiago> diff --git a/gdb/configure.ac b/gdb/configure.ac
> Thiago> index fb43cd10d6c8..715001384177 100644
> Thiago> --- a/gdb/configure.ac
> Thiago> +++ b/gdb/configure.ac
> Thiago> @@ -119,6 +119,12 @@ GDB_AC_WITH_DIR(DEBUGDIR, separate-debug-dir,
> Thiago>      [look for global separate debug info in this path @<:@LIBDIR/debug@:>@],
> Thiago>      [${libdir}/debug])
>  
> Thiago> +AC_ARG_WITH(additional-debug-dirs,
> Thiago> +AS_HELP_STRING([--with-additional-debug-dirs=PATHs],
> Thiago> +  [list of additional directories to search for separate debug info]),
> Thiago> +[AC_DEFINE_UNQUOTED(ADDITIONAL_DEBUG_DIRS, "${withval}",
> Thiago> +  Additional directories to look for separate debug info.)])
>
> It's a nit but I think it's normal to indent the body of AC_ARG_WITH.

Ah, I hadn't noticed. Fixed.

> Thiago> +#ifdef ADDITIONAL_DEBUG_DIRS
> Thiago> +  debug_file_directory = debug_file_directory + DIRNAME_SEPARATOR
> Thiago> +    + ADDITIONAL_DEBUG_DIRS;
> Thiago> +#endif
>
> gdb style is to put parens around the RHS of the assignment in this
> case, and indent the 2nd line to line up.

That's true. Fixed.

> I think a new configure switch could use at least a NEWS entry.

Ah, I didn't know new configure options also got NEWS entries.
Added one.

> I didn't see --with-separate-debug-dir in the docs, so there's maybe not
> a natural place for this there.

I actually found a good spot for it, so I mentioned the new option
there.

I'm sending a v2 with these changes shortly.

-- 
Thiago