Re: [PATCH v3 3/4] gdb, intel-classic-compilers, testsuite: workaround icc/icpc/ifort pointer/reference DWARF

[Thiago Jung Bauermann <thiago.bauermann@linaro.org>]

Hello,

Abdul Basit Ijaz via Gdb-patches <gdb-patches@sourceware.org> writes:

> ---
>  gdb/gdbtypes.c                                |  94 +++++++++-
>  gdb/gdbtypes.h                                |   5 +
>  .../icc-ifort-pointers-and-references.c       |  38 ++++
>  .../icc-ifort-pointers-and-references.exp     | 169 ++++++++++++++++++
>  gdb/testsuite/gdb.fortran/pointers.exp        |  86 +++++++--
>  gdb/valprint.c                                |  34 ++++
>  6 files changed, 409 insertions(+), 17 deletions(-)
>  create mode 100644 gdb/testsuite/gdb.dwarf2/icc-ifort-pointers-and-references.c
>  create mode 100644 gdb/testsuite/gdb.dwarf2/icc-ifort-pointers-and-references.exp

This patch reorganizes the code a bit, but still uses the same approach
as v2. Have you tried implementing the approach suggested by Tom Tromey
in https://inbox.sourceware.org/gdb-patches/87fscoepd5.fsf@tromey.com/ ?

> diff --git a/gdb/testsuite/gdb.dwarf2/icc-ifort-pointers-and-references.c b/gdb/testsuite/gdb.dwarf2/icc-ifort-pointers-and-references.c
> new file mode 100644
> index 00000000000..0c0be751833
> --- /dev/null
> +++ b/gdb/testsuite/gdb.dwarf2/icc-ifort-pointers-and-references.c
> @@ -0,0 +1,38 @@
> +/* This testcase is part of GDB, the GNU debugger.
> +
> +   Copyright 2021-2023 Free Software Foundation, Inc.

The copyright starts in 2023.

> +
> +   This program is free software; you can redistribute it and/or modify
> +   it under the terms of the GNU General Public License as published by
> +   the Free Software Foundation; either version 3 of the License, or
> +   (at your option) any later version.
> +
> +   This program is distributed in the hope that it will be useful,
> +   but WITHOUT ANY WARRANTY; without even the implied warranty of
> +   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> +   GNU General Public License for more details.
> +
> +   You should have received a copy of the GNU General Public License
> +   along with this program.  If not, see <http://www.gnu.org/licenses/>.  */

-- 
Thiago