From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-x52a.google.com (mail-pg1-x52a.google.com [IPv6:2607:f8b0:4864:20::52a]) by sourceware.org (Postfix) with ESMTPS id 368433858D33 for ; Tue, 3 Oct 2023 00:09:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 368433858D33 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-pg1-x52a.google.com with SMTP id 41be03b00d2f7-5789de5c677so172890a12.3 for ; Mon, 02 Oct 2023 17:09:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1696291753; x=1696896553; darn=sourceware.org; h=mime-version:message-id:date:in-reply-to:subject:cc:to:from :user-agent:references:from:to:cc:subject:date:message-id:reply-to; bh=LYgcErdzRY5K7kXLhJPrw8XmvOr4HlVuSv534mvMJpA=; b=ALpgrypuxovot9R1AIJXmQGB8mquB7TZhEAFFq1Yc+Ru5weLLsKJqRN8dnjiGkEcBr AsrHcaM88QVs4Icp98DsHuiiK4anpI0+CxwImpJQRDwqx5aCID36sJwUOM+NmIelb0wK Oa5++/tG+6+ipofGlIqvGSP7c38kwS0+bUh4SSfhs3D7XNcUBehMjG5T/PAsxdn59KDo AZjjx7H4437IBrQynbRTLOubIpKccAL6B0Q8IAX4zQ/MZda0dAEBbt64ksgIKN6DAWzz U7KsaWmDq93ESj/JZdSqZ8HRg0OJ0Av8uigGiKfY6H0RIkGYIfSWcXhvyZL1bx+z9CMa 1VaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696291753; x=1696896553; h=mime-version:message-id:date:in-reply-to:subject:cc:to:from :user-agent:references:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=LYgcErdzRY5K7kXLhJPrw8XmvOr4HlVuSv534mvMJpA=; b=aEC9pjXtV9rZ1YZHJMfifFoFe6ufd0TFUoOVzxBy6Vu9U1CVGV+mvJTyVLYGffSXfo fnusnar/KKqbNfl+iHVJIOcuD2/Md7eq/uUplKzSntdiO+kZ+AWV0GFEPH+tRnuhORY3 H+T1H8MNJj38OnHdye/7rAGwPc6fgmm6K5lTVnV0MtCK5ll7OEjd6fBC2UkkhjbR/iUM R4duBL495cJJOPxSgBvBYnQwS2nbcUSQ0yZ3quQcCNjpf24k3ZLd+wBxgwCqoJmcJKci 0KyW5NJRy3uDGvUG+Sc+veL4PoxnMDIVelEnL0BAcBfbtdULmI2DvvKfQq4QG9zJSIVv CUTg== X-Gm-Message-State: AOJu0YztDvrI6JStAwC7QVoOOhNc41anUhh0ngZBsKWS/fH1pY7P565K 8pDJMQGxY+xztJklJZpKhSP5Mw== X-Google-Smtp-Source: AGHT+IEBpTi/mDQQ6vIN8oKmSyABJtgrvBwqjLgdWlYfg9aQSXPeIY+6iYVfvyaT10MDjz6un7RDtw== X-Received: by 2002:a05:6a20:8e2a:b0:14c:d0c0:dd27 with SMTP id y42-20020a056a208e2a00b0014cd0c0dd27mr12065088pzj.44.1696291753111; Mon, 02 Oct 2023 17:09:13 -0700 (PDT) Received: from localhost ([2804:14d:7e39:8470:c981:e91d:3861:6298]) by smtp.gmail.com with ESMTPSA id jd22-20020a170903261600b001c72f51b84asm44389plb.52.2023.10.02.17.09.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Oct 2023 17:09:12 -0700 (PDT) References: <20230904222956.15203-1-abdul.b.ijaz@intel.com> <20230904222956.15203-4-abdul.b.ijaz@intel.com> User-agent: mu4e 1.10.7; emacs 29.1 From: Thiago Jung Bauermann To: Abdul Basit Ijaz Cc: simark@simark.ca, tom@tromey.com, gdb-patches@sourceware.org Subject: Re: [PATCH v3 3/4] gdb, intel-classic-compilers, testsuite: workaround icc/icpc/ifort pointer/reference DWARF In-reply-to: <20230904222956.15203-4-abdul.b.ijaz@intel.com> Date: Mon, 02 Oct 2023 21:09:09 -0300 Message-ID: <87cyxwefdm.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-11.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hello, Abdul Basit Ijaz via Gdb-patches writes: > --- > gdb/gdbtypes.c | 94 +++++++++- > gdb/gdbtypes.h | 5 + > .../icc-ifort-pointers-and-references.c | 38 ++++ > .../icc-ifort-pointers-and-references.exp | 169 ++++++++++++++++++ > gdb/testsuite/gdb.fortran/pointers.exp | 86 +++++++-- > gdb/valprint.c | 34 ++++ > 6 files changed, 409 insertions(+), 17 deletions(-) > create mode 100644 gdb/testsuite/gdb.dwarf2/icc-ifort-pointers-and-references.c > create mode 100644 gdb/testsuite/gdb.dwarf2/icc-ifort-pointers-and-references.exp This patch reorganizes the code a bit, but still uses the same approach as v2. Have you tried implementing the approach suggested by Tom Tromey in https://inbox.sourceware.org/gdb-patches/87fscoepd5.fsf@tromey.com/ ? > diff --git a/gdb/testsuite/gdb.dwarf2/icc-ifort-pointers-and-references.c b/gdb/testsuite/gdb.dwarf2/icc-ifort-pointers-and-references.c > new file mode 100644 > index 00000000000..0c0be751833 > --- /dev/null > +++ b/gdb/testsuite/gdb.dwarf2/icc-ifort-pointers-and-references.c > @@ -0,0 +1,38 @@ > +/* This testcase is part of GDB, the GNU debugger. > + > + Copyright 2021-2023 Free Software Foundation, Inc. The copyright starts in 2023. > + > + This program is free software; you can redistribute it and/or modify > + it under the terms of the GNU General Public License as published by > + the Free Software Foundation; either version 3 of the License, or > + (at your option) any later version. > + > + This program is distributed in the hope that it will be useful, > + but WITHOUT ANY WARRANTY; without even the implied warranty of > + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > + GNU General Public License for more details. > + > + You should have received a copy of the GNU General Public License > + along with this program. If not, see . */ -- Thiago