From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id C39E13858C1F for ; Tue, 12 Sep 2023 10:44:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C39E13858C1F Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1694515483; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=RGBeyvh8CipbNqwjzfBFeIIigbhgc6WyBF48473IsVE=; b=GTM90tcq2pQSqbKNlDixOdVtKKrHirOoTdPWOLNpdhWjME6n7sE69xf6/5v/XH6p9MlTaW xaX641QoDaa3uexlXWD4S9vB1j3P12aGk69JYE18oTQsIPDcH6EGRbD1XZI/VhF+OZ+gTU T1822i3akY0IazXZk8qJYwFHRp3gGWc= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-321-o8Q5XnqkP3SkUYUpmyRWMQ-1; Tue, 12 Sep 2023 06:44:42 -0400 X-MC-Unique: o8Q5XnqkP3SkUYUpmyRWMQ-1 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-3f5df65fa35so41222665e9.3 for ; Tue, 12 Sep 2023 03:44:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694515481; x=1695120281; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=RGBeyvh8CipbNqwjzfBFeIIigbhgc6WyBF48473IsVE=; b=qY3AFM7HWjmLDN8k2CcZm6ytO/wnyeYqm9ZhRHs8uzZcW3CUzYhElcBZdwcFZXsys2 uz2TrS8Nhuf54RzGtRyJm/ucQfe3fNYucpZdWy4s0nhWUvXDRhlRIUW9GtYgGiM/PLdq ly8n5dHEt9sCOStnla/5cprVnkuRLLKLtDxQoS1nOylnNodVHOk5e1rUZIVflvuOFayC PbuCXr1K6FHV49PMXuOwjda5G4prWd+1A1aZ3Zt1FPDQ0jqhyi4jAadHw9g8O+fju0E8 WGdO01CXzEXAgnLYnRzMpve3pObn3OrndojATmjGNdP3iEsPkqAF4320iItLtQ3l7mgO MIww== X-Gm-Message-State: AOJu0YwT1VWC2gm2chogxJmVCX8/mDWKv9O7Pc7sAWOYYkCMXNu7UZdn +Di9cF5wWZIDgGn1nhg73e0Hvghd7vzgOzSVNmHruogFX35LZD6Ha6lverYFC0/zbmxCS2IIVQ0 3ytdOYxsN00i+0ZAzwwrKGhx6B1v3cs78slqa/u5TPhFPux94zH31Bm7zjD92G/JosM+Hn/2mSP hz7MGWSA== X-Received: by 2002:a05:600c:6010:b0:3fe:e7b2:c97f with SMTP id az16-20020a05600c601000b003fee7b2c97fmr9870677wmb.36.1694515481022; Tue, 12 Sep 2023 03:44:41 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGGlmavf5VlykNEBwQ5y3njqp2KVPEeliwMnfy2xgFvRXKaHKwCo1RXxoSQuOQKgruId5v+Gw== X-Received: by 2002:a05:600c:6010:b0:3fe:e7b2:c97f with SMTP id az16-20020a05600c601000b003fee7b2c97fmr9870664wmb.36.1694515480639; Tue, 12 Sep 2023 03:44:40 -0700 (PDT) Received: from localhost (197.126.90.146.dyn.plus.net. [146.90.126.197]) by smtp.gmail.com with ESMTPSA id k9-20020a05600c0b4900b003fe2b081661sm15921247wmr.30.2023.09.12.03.44.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Sep 2023 03:44:40 -0700 (PDT) From: Andrew Burgess To: Simon Marchi via Gdb-patches , gdb-patches@sourceware.org Cc: Simon Marchi Subject: Re: [PATCH 13/21] gdb/mi: use m_ui instead of current_ui in mi_interp::resume In-Reply-To: <20230908190227.96319-14-simon.marchi@efficios.com> References: <20230908190227.96319-1-simon.marchi@efficios.com> <20230908190227.96319-14-simon.marchi@efficios.com> Date: Tue, 12 Sep 2023 11:44:39 +0100 Message-ID: <87cyynk6w8.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-11.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Simon Marchi via Gdb-patches writes: > No behavior changes expected. > > Change-Id: Ic379a18d6a6d83a55cd4a6d1239d4daa98966cc8 > --- > gdb/mi/mi-interp.c | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) > > diff --git a/gdb/mi/mi-interp.c b/gdb/mi/mi-interp.c > index f260d98837cf..b676e22f3550 100644 > --- a/gdb/mi/mi-interp.c > +++ b/gdb/mi/mi-interp.c > @@ -118,14 +118,13 @@ void > mi_interp::resume () > { > struct mi_interp *mi = this; > - struct ui *ui = current_ui; > > /* As per hack note in mi_interpreter_init, swap in the output > channels... */ > - gdb_setup_readline (ui, 0); > + gdb_setup_readline (m_ui, 0); > > - ui->call_readline = gdb_readline_no_editing_callback; > - ui->input_handler = mi_execute_command_input_handler; > + m_ui->call_readline = gdb_readline_no_editing_callback; > + m_ui->input_handler = mi_execute_command_input_handler; > > gdb_stdout = mi->out; Same stdout question as for the previous two patches. I'm wondering if we're going to have to live in some halfway house for a while, in which case maybe we should be adding an assert like: gdb_assert (current_ui == m_ui); Or maybe I've jut not understood something here (or maybe a later patch fixes all this suff, and I'm just making noise). Thanks, Andrew > /* Route error and log output through the MI. */ > -- > 2.42.0