From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 57E9F3858C01 for ; Wed, 23 Aug 2023 11:36:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 57E9F3858C01 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1692790583; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cR2N2ZI3cB7Ho5ksfZnA6tMiwbmkbBVXjN1JyEVynNk=; b=CJzC6bKOdAXexGSFQ6fPOWKzTMmARnm4BE7uil50Sr/IBAUACSzV7S55zn7RsvzhgYuiMr uFsyqK8gpv7y+O1YfTCJYc80MPJHMuIRNVP3nr7vBOgG4xmy9ndchTLEHoaqmYiQdiCbN2 +FpSNjHEAao469Ah3BPbzCkfyh/nfsI= Received: from mail-lf1-f71.google.com (mail-lf1-f71.google.com [209.85.167.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-424-zPvzCmQOMnWEmQagjpN1KA-1; Wed, 23 Aug 2023 07:36:21 -0400 X-MC-Unique: zPvzCmQOMnWEmQagjpN1KA-1 Received: by mail-lf1-f71.google.com with SMTP id 2adb3069b0e04-4ff9b3ead6fso5479203e87.2 for ; Wed, 23 Aug 2023 04:36:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692790580; x=1693395380; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=z+Dxo64bRRGFbwF8e9sFNDdkQEi1rQOHh41sm9Kw8pM=; b=iFkfSv+GYoCsNGzHKFZyQ5BVRKTO7kMwskuOWmt/T/ibT+BTHK5IAvxURrhaDuTr1t 2KR5t8Z4JMYhz7uL4g27qWf7NmSkd+LMbiWkSkMmDBsxBcu2C13ALpzOCYCAIxfkFs0e +Lh65RZkeZiicsg2pa/QazPWwFeD3lFyZaT2a9WHKdOeqAy2oRKaFNHXu4F3MzMhRFM0 epF+Gtq+lgvairCcudYkQsLFlDvBABuxKT3TnSCEpnFuN5VMbKQLRb7ESEGm9MzzmYX8 zatKPtj6EEELgLoSkAFoLefuOW4nZ5GHzCLHtsIvEr4ap6mGQtU8tXGibjyDWhLtxdGX NnIQ== X-Gm-Message-State: AOJu0Yz9Kaqq6Zl0MBUCcI8OP8Jm/kKRtJ19BcAUgvJaiKVsBc/4FLzX lt734ViVgShrAX1BrxG1lnjYQWEVmgvI+MpqeIrZfdJjeCXuj38K6tp33lKyv8U2irBLlJV1qLK bE6CtWADU24RdjLfbzyuPcA== X-Received: by 2002:a05:6512:2247:b0:500:83d0:a0ee with SMTP id i7-20020a056512224700b0050083d0a0eemr7468408lfu.69.1692790580341; Wed, 23 Aug 2023 04:36:20 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHsebONVeNp9aQikSVnithJ1G23LrW+Te8iCsK2fKN3uV8ZGk3BuVI/LUi8mrET/oekDpjCHQ== X-Received: by 2002:a05:6512:2247:b0:500:83d0:a0ee with SMTP id i7-20020a056512224700b0050083d0a0eemr7468397lfu.69.1692790579982; Wed, 23 Aug 2023 04:36:19 -0700 (PDT) Received: from localhost ([31.111.84.232]) by smtp.gmail.com with ESMTPSA id q24-20020aa7cc18000000b0052567e6586bsm9278340edt.38.2023.08.23.04.36.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Aug 2023 04:36:19 -0700 (PDT) From: Andrew Burgess To: Mark Wielaard , gdb-patches@sourceware.org Cc: Alexandra Petlanova Hajkova Subject: Re: [PATCH 07/10] gdb: add qMachineId packet In-Reply-To: <62e6f9f8bf689e8f64b986afaefc4928bde3093a.camel@klomp.org> References: <94e68e6c1400ede2e9e46fc8ef76bd82aa533e0e.1692200989.git.aburgess@redhat.com> <62e6f9f8bf689e8f64b986afaefc4928bde3093a.camel@klomp.org> Date: Wed, 23 Aug 2023 12:36:18 +0100 Message-ID: <87cyzeat3h.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-11.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Mark Wielaard writes: > Hi Andrew, > > On Wed, 2023-08-16 at 16:55 +0100, Andrew Burgess wrote: >> diff --git a/gdbserver/server.cc b/gdbserver/server.cc >> index e749194e039..ae40e885e70 100644 >> --- a/gdbserver/server.cc >> +++ b/gdbserver/server.cc >> @@ -51,6 +51,8 @@ >> =C2=A0#include "gdbsupport/scoped_restore.h" >> =C2=A0#include "gdbsupport/search.h" >> =C2=A0 >> +#include >> + >> =C2=A0/* PBUFSIZ must also be at least as big as IPA_CMD_BUF_SIZE, becau= se >> =C2=A0=C2=A0=C2=A0 the client state data is passed directly to some agen= t >> =C2=A0=C2=A0=C2=A0 functions.=C2=A0 */ > > This include is only available when systemd-devel headers are > installed. But it seems not to be used, so can just be removed as far > as I can tell. Thanks for spotting that. An earlier version of this patch made use of sd_id128_get_machine, but in the end I figured it was easier just to read the file directly. I've fixed this locally for now, the fix will be in V2. Thanks, Andrew