From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io1-xd32.google.com (mail-io1-xd32.google.com [IPv6:2607:f8b0:4864:20::d32]) by sourceware.org (Postfix) with ESMTPS id E4DAE3858415 for ; Mon, 31 Jul 2023 14:30:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E4DAE3858415 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com Received: by mail-io1-xd32.google.com with SMTP id ca18e2360f4ac-78374596182so219432839f.0 for ; Mon, 31 Jul 2023 07:30:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1690813806; x=1691418606; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=9F1iWMn08szEmmEO+VOPxsrPs02dF8RSB5bu1HZOUhE=; b=SX+36K1wyuz/+rdS3cBLhODwCCoyJrhufdAo4vNIxtr60fjFxyatqNGHZWiHHeoAUH mQCRx3AJ2ny/hXREGnX8szrtIS+sb2TFPySrDZi0CE9C7pWSeDTEj2w2DJ6hxCFgAE61 +dKQJgXCNAUtkSMk56DmD7ZTtZriao3jRupJgoghKKHIqYQMkKgfMqF7BO7XaKQwWUNv cU/vBJ7fYArnfZvQMx3u/gX3CbL2Fdj17cz7m6lBfeS/d+5/G/q2Y643WPqbiA6r0CkR ewznCb+wAUMJZBwmtIcuvrsnPSWtoDY4KHRwBZzC8Nwu4wDvm+bY8Q784CZJwkvkCJMP gULg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690813806; x=1691418606; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=9F1iWMn08szEmmEO+VOPxsrPs02dF8RSB5bu1HZOUhE=; b=J2VCWylHbmne2a8g3ZaqzVUDynheCJPBbRkxR7N2KC3KEHMoSnjFGAU6jEE8KWkGME csVvtD71YbIf8um3zvIbLPvm3xJ67jL57DDcmk2HyFbx02wCEP6YBQ6LFmqV2ef4x3NG 8Ua53nLm9axiSAGYCFPfRTlwVXzNtvhvaARRyw30BGEWadiBSXTt/HYbauATneq9BZfF Mx49+mKTK+oRt3IT976TpJT3f97K+0DYD65RaOeE11wxHSbMbXuZf2kP672WCCwT7m+3 CX5YVDR1GVuRWzD2a7s8pfgPsq54NYxBCvs41unWa97AOU6fhDotzILSFcBJp4cFQHoc A72g== X-Gm-Message-State: ABy/qLblG/blEoSSNhR10IRGaThDG0A+KDOI2RS79qkwlNkxGV/WhRFM ZEbtbhYTDPiE/5fAbBujqpHVKsFn11tji8Gk+ntnXw== X-Google-Smtp-Source: APBJJlHB1gN9CUk84H3X6d20SJob2yd/IO7LpGNeiVCKYAHHx+/q0bFewToXf1/hRsKptcqQwap7jw== X-Received: by 2002:a5d:924b:0:b0:785:cfa1:fcac with SMTP id e11-20020a5d924b000000b00785cfa1fcacmr8153498iol.20.1690813806178; Mon, 31 Jul 2023 07:30:06 -0700 (PDT) Received: from murgatroyd (75-166-135-140.hlrn.qwest.net. [75.166.135.140]) by smtp.gmail.com with ESMTPSA id e6-20020a5d85c6000000b007836a9ca101sm3321385ios.22.2023.07.31.07.30.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 31 Jul 2023 07:30:05 -0700 (PDT) From: Tom Tromey To: Lancelot SIX Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH 1/6] Rename private member of FrameDecorator References: <20230725-dap-bt-path-v1-0-bb015b0d8e54@adacore.com> <20230725-dap-bt-path-v1-1-bb015b0d8e54@adacore.com> <20230728145046.waxsfe2w2yhklkfa@octopus> X-Attribution: Tom Date: Mon, 31 Jul 2023 08:30:05 -0600 In-Reply-To: <20230728145046.waxsfe2w2yhklkfa@octopus> (Lancelot SIX's message of "Fri, 28 Jul 2023 15:50:46 +0100") Message-ID: <87cz08gnma.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-5.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Lancelot" == Lancelot SIX writes: Lancelot> I do not object to this change, I am just noting that nothing is really Lancelot> private in Python, and it seems to me that the commit message promises Lancelot> otherwise. I've reworded it to: In Python, a member name starting with "__" is specially handled to make it "more private" to the class -- it isn't truly private, but it is renamed to make it less likely to be reused by mistake. Tom