From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from outbound-ss-820.bluehost.com (outbound-ss-820.bluehost.com [69.89.24.241]) by sourceware.org (Postfix) with ESMTPS id 65C223858D1E for ; Thu, 13 Jul 2023 16:34:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 65C223858D1E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw10.mail.unifiedlayer.com (unknown [10.0.90.125]) by progateway2.mail.pro1.eigbox.com (Postfix) with ESMTP id B1D461004CD34 for ; Thu, 13 Jul 2023 16:34:28 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id JzGuqWFaPtHbOJzGuqjQp9; Thu, 13 Jul 2023 16:34:28 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=C70sdSD+ c=1 sm=1 tr=0 ts=64b02794 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=OWjo9vPv0XrRhIrVQ50Ab3nP57M=:19 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=ws7JD89P4LkA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=ANwu_DJDGFDdnziy8d4A:9 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=/73VzSyJk7++F4S22fg8IgxmdN0yt9uAU48IN0/m1XA=; b=F59icMQBoQB16uZdE0PA4WJ6Kq AlnrVi1gqFDtbflG4tDht/MGAO5AzE0p1nDPOtYlPWZcDUNI2hS/UJ5C517SO8roZHmkJzbfAPCsJ C17alUP05EH6mLVI8yxQbt6iP; Received: from 75-166-135-140.hlrn.qwest.net ([75.166.135.140]:50132 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1qJzGu-003iv6-0v; Thu, 13 Jul 2023 10:34:28 -0600 From: Tom Tromey To: Rainer Orth Cc: gdb-patches@sourceware.org, Andrew Burgess Subject: Re: [PATCH] Guard against killing unrelated processes in amd64-disp-step.exp References: X-Attribution: Tom Date: Thu, 13 Jul 2023 10:34:27 -0600 In-Reply-To: (Rainer Orth's message of "Thu, 13 Jul 2023 13:19:55 +0200") Message-ID: <87cz0vpy7g.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.135.140 X-Source-L: No X-Exim-ID: 1qJzGu-003iv6-0v X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-135-140.hlrn.qwest.net (murgatroyd) [75.166.135.140]:50132 X-Source-Auth: tom+tromey.com X-Email-Count: 4 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3019.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Rainer" == Rainer Orth writes: Rainer> When testing current gdb trunk on Solaris/amd64, the whole session was Rainer> reliably terminated by make check. I could trace this to the following Rainer> entry in gdb.arch/amd64-disp-step/gdb.log: Thank you for the patch. Rainer> If $inferior_pid doesn't refer a single process for some reason, this Rainer> kill would terminate either a process group or the whole session. I don't mind the patch, it seems like an improvement -- but I wonder why this ends up as -1, and whether a fix belongs elsewhere. Tom