From: Tom Tromey <tom@tromey.com>
To: Keith Seitz <keiths@redhat.com>
Cc: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Allow pretty-print of static members
Date: Sat, 06 May 2023 10:34:42 -0600 [thread overview]
Message-ID: <87cz3d7719.fsf@tromey.com> (raw)
In-Reply-To: <cfaf2480-cd03-0fa7-7da9-addfded869be@redhat.com> (Keith Seitz's message of "Fri, 5 May 2023 11:38:48 -0700")
>>>>> "Keith" == Keith Seitz <keiths@redhat.com> writes:
>> Python pretty-printers haven't applied to static members for quite
>> some time. I tracked this down to the call to cp_print_value_fields
>> in cp_print_static_field -- it doesn't let pretty-printers have a
>> chance to print the value. This patch fixes the problem.
Keith> I never noticed, either, and it LGTM.
Keith> Reviewed-by: Keith Seitz <keiths@redhat.com>
Keith> Tested-by: Keith Seitz <keiths@redhat.com>
Thanks, I'm going to check it in.
>> The way that static members are handled is very weird to me. I tend
>> to think this should be done more globally, like in value_print.
>> However, I haven't made any big change.
Keith> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Keith> Yet? ;-)
Well, I gave it a bit of a try but ran into some difficulties and
decided it would be good to just get a fix in.
Tom
prev parent reply other threads:[~2023-05-06 16:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-27 14:31 Tom Tromey
2023-05-05 18:38 ` Keith Seitz
2023-05-06 16:34 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87cz3d7719.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=keiths@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).