From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from alt-proxy28.mail.unifiedlayer.com (alt-proxy28.mail.unifiedlayer.com [74.220.216.123]) by sourceware.org (Postfix) with ESMTPS id 689D93858D1E for ; Tue, 2 May 2023 15:12:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 689D93858D1E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw10.mail.unifiedlayer.com (unknown [10.0.90.125]) by progateway1.mail.pro1.eigbox.com (Postfix) with ESMTP id C5CD11003B6E8 for ; Tue, 2 May 2023 15:12:56 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id trgWph6QRz6C2trgWpfcOh; Tue, 02 May 2023 15:12:56 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=KZgXDSUD c=1 sm=1 tr=0 ts=64512878 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=P0xRbXHiH_UA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=n9Nvxce8AAAA:8 a=Fz-BmCQ2odsbTNMnocEA:9 a=V4tbcg9hxeXQX3VEsxKP:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=w5KXKmsQFeBVfHgvzrXfCAMAYH4VJc9HLJBWVDgxk1E=; b=sqTJkf1lCI4NSlaSOdIRjuFboI W7Is10fsRxlc9OHY5SRWgpAdlHmH6s7RPlp06zJMoN7zE3xbiEBsk0ous4oE+9MaaXgPpkZEv3Y/6 EwvwJrLR2KxfsW6z9412WJ0Jq; Received: from 71-211-191-82.hlrn.qwest.net ([71.211.191.82]:44044 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1ptrgW-002lsg-F7; Tue, 02 May 2023 09:12:56 -0600 From: Tom Tromey To: Mark Wielaard Cc: gdb-patches@sourceware.org, Simon Marchi Subject: Re: [PATCHv2] xcoffread.c: Fix -Werror=dangling-pointer= issue with main_subfile. References: <20230501181401.GH3078@gnu.wildebeest.org> <20230501181948.1407024-1-mark@klomp.org> X-Attribution: Tom Date: Tue, 02 May 2023 09:12:55 -0600 In-Reply-To: <20230501181948.1407024-1-mark@klomp.org> (Mark Wielaard's message of "Mon, 1 May 2023 20:19:49 +0200") Message-ID: <87cz3ivkaw.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 71.211.191.82 X-Source-L: No X-Exim-ID: 1ptrgW-002lsg-F7 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 71-211-191-82.hlrn.qwest.net (murgatroyd) [71.211.191.82]:44044 X-Source-Auth: tom+tromey.com X-Email-Count: 5 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3019.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Mark" == Mark Wielaard writes: Mark> GCC 13 points out that main_subfile has local function scope, but a Mark> pointer to it is assigned to the global inclTable array subfile Mark> element field: Thanks, Mark. This is ok. All this code seems very bit-rotted to me. Like, it seems to me that it doesn't even properly handle multiple objfiles, a genuinely ancient addition to gdb. I wonder whether it could be removed. Tom