From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 99CC4385697F for ; Thu, 6 Apr 2023 15:38:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 99CC4385697F Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1680795510; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=9PbwNhzR8mBszp3YTB+EWTnlyCQuLfB3ixh+/M7n2PE=; b=R4GHCWva2A50Ex4lJoXUdmPM0iFxRG3GWK3W5uZ5fbcGNzjHutynWHRtE2pJR4psJhg7hU V2qquGkMFth1ZcQi1DqTp0I5SszjrF/cKEpRDyaIPRU9ufysX7NhXVVNYEhSRENDgSvEoZ o0owCXGRk3GoLKiWT2lUz2Y8DhJNeSw= Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-657-FjIw2n4COK-bE2o0oSdy4A-1; Thu, 06 Apr 2023 11:38:29 -0400 X-MC-Unique: FjIw2n4COK-bE2o0oSdy4A-1 Received: by mail-qt1-f197.google.com with SMTP id y10-20020a05622a164a00b003e38e0a3cc3so26846942qtj.14 for ; Thu, 06 Apr 2023 08:38:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680795508; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=9PbwNhzR8mBszp3YTB+EWTnlyCQuLfB3ixh+/M7n2PE=; b=7MWoGQsQtSd/UDYqWQj2HEk8clkvYhQ32c76liOlV6us7hP3x5+ifq7bUDVWRaqcYy 6DtKnOrUj4CJ3+eJqqlWDP9UXo/zBPsB4FALQQBB0CE5JSgCaaHMM801rOxO/bsd2DMM yVt1H8dXveeZivecMfZbFE/gUDvLukVmp9YZl0HSj+6h1xGEPX59H6Mc2Y9/lB9q+qsv GOpkIcmf/63hg0fTTM0+lIDjNtJbMYEe/YurIIvTrNv+im/YOD4iSMZgLp87Yn8FMOGc Grjg2653bg6ZH6BvE5gBp2I51UHdjQ6ZfcTA3lr+u6XjyfcNQqsYWtnLNz1hwVoQa6ei PuCQ== X-Gm-Message-State: AAQBX9doRISc0hHb+DdxhjqXnHdHOEHa/WRvT5wE0D4lZEezd7EyFU3+ BBWlEBlBtVdLjP0nioE43zDxMA0EAQd/lRBYedTUBCjjANaPBrr/2K6jv/9M6Z64fI9ebP+edJO fNBljUVrzf28buyDV8BTm1oMnu45WGw== X-Received: by 2002:a05:622a:1343:b0:3e4:d1c0:36a9 with SMTP id w3-20020a05622a134300b003e4d1c036a9mr12791184qtk.48.1680795508139; Thu, 06 Apr 2023 08:38:28 -0700 (PDT) X-Google-Smtp-Source: AKy350bCx96QpgWSEg+cCBo2HDjFaKCAObdvGiObJXnb3yEMZAXbxRrdVWYJcKliPZvZAWQlUZxtdg== X-Received: by 2002:a05:622a:1343:b0:3e4:d1c0:36a9 with SMTP id w3-20020a05622a134300b003e4d1c036a9mr12791140qtk.48.1680795507861; Thu, 06 Apr 2023 08:38:27 -0700 (PDT) Received: from localhost (95.72.115.87.dyn.plus.net. [87.115.72.95]) by smtp.gmail.com with ESMTPSA id y79-20020a376452000000b007467a4d8691sm553752qkb.47.2023.04.06.08.38.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Apr 2023 08:38:25 -0700 (PDT) From: Andrew Burgess To: Pedro Alves , gdb-patches@sourceware.org Cc: Simon Marchi Subject: Re: [PATCHv4] gdb: fix reg corruption from displaced stepping on amd64 In-Reply-To: <87o7o1b0ks.fsf@redhat.com> References: <49d7093fe09ea127d7dfd6082695ccda23d62439.1680097352.git.aburgess@redhat.com> <87o7o1b0ks.fsf@redhat.com> Date: Thu, 06 Apr 2023 16:38:23 +0100 Message-ID: <87cz4haumo.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-11.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,KAM_NUMSUBJECT,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Andrew Burgess writes: > Pedro Alves writes: > >> On 2023-03-29 2:46 p.m., Andrew Burgess wrote: >>> In v4: >>> >>> - The first two patches, which related to displaced step debugging, >>> have now been merged, >>> >>> - The test now uses 'remote_exec target "kill ...' as suggested by >>> Pedro, I've confirmed that the test still exposes the issue when >>> the GDB fix is not applied, >>> >>> - Have regenerated the gdbarch related files. The only change to >>> generated code is within a comment -- so no functional change, >>> >>> - All the typos and gramatical errors Pedro pointed out have been >>> fixed, >>> >>> - The trailing blank lines that Simon pointed out have been removed. >>> >> >> Thank you. >> >> Approved-By: Pedro Alves > > Pushed. And buildbot pointed out that I failed to run black on gdbarch_components.py. I pushed the following patch to fix the formatting. Thanks, Andrew --- commit a52aeef9237096bbde1c3092a4860d12c3778ffb Author: Andrew Burgess Date: Thu Apr 6 16:34:17 2023 +0100 gdb: run black code formatter on gdbarch_components.py The following commit changed gdbarch_components.py but failed to format it with black: commit cf141dd8ccd36efe833aae3ccdb060b517cc1112 Date: Wed Feb 22 12:15:34 2023 +0000 gdb: fix reg corruption from displaced stepping on amd64 This commit just runs black on the file and commits the result. The change is just the addition of an extra "," -- there will be no change to the generated source files after this commit. There will be no user visible changes after this commit. diff --git a/gdb/gdbarch_components.py b/gdb/gdbarch_components.py index d30c537ee1c..9f0430c7770 100644 --- a/gdb/gdbarch_components.py +++ b/gdb/gdbarch_components.py @@ -1804,7 +1804,7 @@ see the comments in infrun.c. ("CORE_ADDR", "from"), ("CORE_ADDR", "to"), ("struct regcache *", "regs"), - ("bool", "completed_p") + ("bool", "completed_p"), ], predicate=False, predefault="NULL",