From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-il1-x132.google.com (mail-il1-x132.google.com [IPv6:2607:f8b0:4864:20::132]) by sourceware.org (Postfix) with ESMTPS id CB5383858C2C for ; Tue, 7 Mar 2023 18:59:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org CB5383858C2C Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com Received: by mail-il1-x132.google.com with SMTP id b12so5373861ilf.9 for ; Tue, 07 Mar 2023 10:59:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1678215557; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=W8iVET7mulmFItf3hlQiixbfnKQDxdTT504UJhCUpuE=; b=eEcnovklEVgMv3bFzZtPtiQiRXJ7nhvb5XNjpVEIrcgAgRCgnR1kASFF0GMI8Exfrd uUTmEDj5lIT2mSMQ6xzatVS+7n9ldxYXpcvVEnaa4nQF8fMtde2bgs1GiLX514R+LGPA BjsZptc9mNURG17NVemcQE/Az6NRWyg2/Fc8U8hRG+7vf4Ki+ELtrknGiES9o1zZ791N THom/MOANohcW0mVRSIIc5VHdz5O49UT/QH5bSN4XJm8ETwYpqrSoWKc6emUSaD9Mirn DtfuJevsXEq9UYPNrwGp2yHVhFEvjLD1fMs8R1nKsTFDwAIPFcjkJhfbPj9JcqYCJJeW nh0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678215557; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=W8iVET7mulmFItf3hlQiixbfnKQDxdTT504UJhCUpuE=; b=Ny3q45DCqMbxx0XY11wWRbvZaOOzJC1UmIoSQmKZaAJUSjmT4Kn8ZMxSVkd9vD48DQ i6WXM0CXovnO5z4MPFa61AzliWuRkolfMQo0o2+7AAOxunqLtEEF5Bz1i80Yc7Y+LKva 3DA2u5lldFOv0x/PHmGwTyZhnzco+qQhWdURSnPyPkOrdTS5IOIb0YFrdabc+hojGVC0 aePKIfrXgKTlZkXlsBIva1Zz9jikma6wW1PuJKgpBNXa6ATt+mBlw6l7uvQgq2+2+Y1L Q177SfXTIrVMXze5h0FMeLZQLVRBRizrn9a25deK9QA6b9zOGkv1zWGN7hEAmYkL+6OM gH3Q== X-Gm-Message-State: AO0yUKVJW9280A9wEqD3618itzi2VwAfnVvPgFOdv+ktdJP+p4YvHwLS nexacyfZZDacmc0lHmw1ZBotMQ== X-Google-Smtp-Source: AK7set8qUuINmr4KoWKkYkTQlwiYfXEWO14IJi1MD0x33COX99NJXXsZW/m7Blom5cjscjzVbk5uHw== X-Received: by 2002:a92:1a4f:0:b0:31a:97f:8422 with SMTP id z15-20020a921a4f000000b0031a097f8422mr9732823ill.31.1678215557102; Tue, 07 Mar 2023 10:59:17 -0800 (PST) Received: from murgatroyd (75-166-130-93.hlrn.qwest.net. [75.166.130.93]) by smtp.gmail.com with ESMTPSA id f13-20020a056e0204cd00b003179d4bd50asm3953273ils.75.2023.03.07.10.59.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Mar 2023 10:59:16 -0800 (PST) From: Tom Tromey To: Ulrich Weigand via Gdb-patches Cc: "tdevries@suse.de" , "cel@us.ibm.com" , Ulrich Weigand , "will_schmidt@vnet.ibm.com" Subject: Re: [PATCH] PowerPC, fix gdb.base/retval-large-struct.exp References: <71926c391f43cee2051ea0c9b449ec0aecc847ec.camel@us.ibm.com> X-Attribution: Tom Date: Tue, 07 Mar 2023 11:59:15 -0700 In-Reply-To: (Ulrich Weigand via Gdb-patches's message of "Fri, 18 Nov 2022 16:04:53 +0000") Message-ID: <87cz5ks7zw.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-11.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Ulrich" == Ulrich Weigand via Gdb-patches writes: Ulrich> No, it's not really powerpc specific - the same mechanism can be Ulrich> used on many other platforms with an ABI that uses a return buffer Ulrich> address that is not preserved. (E.g. we're currently looking into Ulrich> enabling it on s390x.) I am curious if it makes sense to enable for 32-bit PPC. That is, the appended seems to help with a "large struct return" test case we have internally, but I don't know the PPC ABI well enough to know if it's really correct, or if it's just working by accident. Tom diff --git a/gdb/rs6000-tdep.c b/gdb/rs6000-tdep.c index 261ce77345e..218fb35efed 100644 --- a/gdb/rs6000-tdep.c +++ b/gdb/rs6000-tdep.c @@ -8249,7 +8249,11 @@ rs6000_gdbarch_init (struct gdbarch_info info, struct gdbarch_list *arches) ppc64_sysv_get_return_buf_addr); } else - set_gdbarch_return_value (gdbarch, ppc_sysv_abi_return_value); + { + set_gdbarch_return_value (gdbarch, ppc_sysv_abi_return_value); + set_gdbarch_get_return_buf_addr (gdbarch, + ppc64_sysv_get_return_buf_addr); + } /* Set lr_frame_offset. */ if (wordsize == 8)