From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-il1-x131.google.com (mail-il1-x131.google.com [IPv6:2607:f8b0:4864:20::131]) by sourceware.org (Postfix) with ESMTPS id 1BADE3858D33 for ; Thu, 16 Feb 2023 18:16:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1BADE3858D33 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com Received: by mail-il1-x131.google.com with SMTP id t7so1075217ilq.2 for ; Thu, 16 Feb 2023 10:16:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=MM4Q/La/vqdhN2F9NCHab0rVeUlV62HLf06ByfAI2Dw=; b=Ex+uJt/L+bAX6uEEjao4Pi55GRw2GGP8ccHTBhauyor0E1keIUTl6yOTUNriu018Fs oaAMRffFpYnAbZKg70d4lbCpkqzxRpJM2EJY/FQBXzyVz/ZaYVPtpDwz4vG1Ow1Qnrj6 wd4pFegHY1BVoAyzzZQX4TXdwelTvFrnImThuR0skaWOPtZw6ZwQjnTe0lGUXEugFn8F 6Wz1sJxx5124vg5XTuuyzVO7GfJAUYk/GGHpdmA0AFpayccfvYLN4qaGc/PP4r8TOpZE G+hNcz1dBjIb4hiyxBsx5yH2+19OB22jDfkh4ZlDwf9hO4McO4ZCHcJFZmckzSr2XAEl v6bQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=MM4Q/La/vqdhN2F9NCHab0rVeUlV62HLf06ByfAI2Dw=; b=hLfyq6QOZVmgN0mrvLSSTEn3U9+D9XDZ0g9e+/pbeg/x61BDHq/DFs7etvpt/MTp8c pb11F5SvgkIrTSm3872Ntr85F70M70xMy/MsXlFRknQ4kl/i37EzSec+IqoPeC6RAgF0 R4HkXckZJCZBOB0pAj5jcUScSKSopwtkXfQuK37VBSvVww4tL4u+KTgTU3BePJ3DjtvX TnMT4UJVPz123PhGniL4gFt7Z19l+1AjtERhzpPWybzY03gSOYocD5XQxkTJ63sun7Ua LJt3H8ZVlvtGFqsHQwlSJ+PA7b4K5uyg54rQjite2aisaEGLEPBzvicyYeotkMfj7B4g F1dQ== X-Gm-Message-State: AO0yUKUAUMnXEGvtoV5ZURK3KrrF2CDRTMdp2K4Bw2FJg0Mjju+QirNe s0l0tSXPZS4C8bCBLP+8VFv3RA== X-Google-Smtp-Source: AK7set94C63Yh5MI0kHG+JZos7vzHIZJOrTmrxMvSAHKrDLTBwm+Z+sYmOOZyOK8VgEOtkO3J0WV5Q== X-Received: by 2002:a05:6e02:1a27:b0:315:5141:339a with SMTP id g7-20020a056e021a2700b003155141339amr5190444ile.7.1676571392348; Thu, 16 Feb 2023 10:16:32 -0800 (PST) Received: from murgatroyd (75-166-130-93.hlrn.qwest.net. [75.166.130.93]) by smtp.gmail.com with ESMTPSA id r20-20020a02c854000000b003c4ec576030sm772512jao.4.2023.02.16.10.16.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Feb 2023 10:16:31 -0800 (PST) From: Tom Tromey To: Pedro Alves Cc: Tom Tromey , Eli Zaretskii , gdb-patches@sourceware.org Subject: Re: [PATCH v2] Update the 'g' packet documentation References: <20230111183725.2902496-1-tromey@adacore.com> <533a8893-c0b2-ec5a-fa11-f83bf98f4429@palves.net> <87lem645yr.fsf@tromey.com> <87o7qfn2qy.fsf@tromey.com> <459e115b-5dff-2e37-46aa-9e8e7495536a@palves.net> X-Attribution: Tom Date: Thu, 16 Feb 2023 11:16:31 -0700 In-Reply-To: <459e115b-5dff-2e37-46aa-9e8e7495536a@palves.net> (Pedro Alves's message of "Thu, 16 Feb 2023 17:10:38 +0000") Message-ID: <87cz69pjb4.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-5.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Pedro" == Pedro Alves writes: >> While I agree with that, it's also the case that tdep code can reject >> such a description, and we ran into a case like this in the wild -- >> where a gdbserver does not report a register, causing i386-tdep to >> reject the description. However, at one point AdaCore had a port for >> this target, and that port reported the register but sent back 'x' -- >> which worked. Pedro> Curious. It sounds like we made some register in a tdesc feature Pedro> mandatory, even after the tdesc feature existed in previous Pedro> releases? That shouldn't have happened. No, we are in the clear, what happened is that a vendor out there hacked gdbserver to drop a register (the x86 "fop" register) for reasons we do not know. They also hacked their gdb to accept this. AdaCore also had a patch for this target's gdbserver to not supply "fop" (the kernel, mysteriously, does not make it available) -- but did not change the XML or gdb, instead having the register report as unavailable. Tom