From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gproxy2-pub.mail.unifiedlayer.com (gproxy2-pub.mail.unifiedlayer.com [69.89.18.3]) by sourceware.org (Postfix) with ESMTPS id 8D6F13897A0C for ; Thu, 15 Dec 2022 21:29:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 8D6F13897A0C Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw15.mail.unifiedlayer.com (unknown [10.0.90.130]) by progateway4.mail.pro1.eigbox.com (Postfix) with ESMTP id D113F10048254 for ; Thu, 15 Dec 2022 21:29:25 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id 5vnBp2TAlPmV95vnBp822c; Thu, 15 Dec 2022 21:29:25 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=Z4EpoFdA c=1 sm=1 tr=0 ts=639b91b5 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=sHyYjHe8cH0A:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=CCpqsmhAAAAA:8 a=bEWyg7bxFmocEZ0sJCkA:9 a=ul9cdbp4aOFLsgKbc677:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=y0aJs9BXeMSRstjNgPchD+TVTY9u9xNbAJZ4oBcnt90=; b=q32jUdPxJv13HapL/zZUf5Heb4 C0KbwFeMoOkpYbnVBrS35t2aCGWE10JC1OWztyDWwR7Gy7QhoG1BASWvdRph4NS7fEx76Vax3w5mY R6TSXWA8EV+v8R4+YDnHqQmph; Received: from 97-122-76-186.hlrn.qwest.net ([97.122.76.186]:56994 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1p5vnB-000lJm-JG; Thu, 15 Dec 2022 14:29:25 -0700 From: Tom Tromey To: Bruno Larsen via Gdb-patches Cc: Bruno Larsen Subject: Re: [PATCH] gdb: add 'maintenance print record-instruction' command References: <20221207135000.1344331-1-blarsen@redhat.com> X-Attribution: Tom Date: Thu, 15 Dec 2022 14:29:21 -0700 In-Reply-To: <20221207135000.1344331-1-blarsen@redhat.com> (Bruno Larsen via Gdb-patches's message of "Wed, 7 Dec 2022 14:50:00 +0100") Message-ID: <87cz8kcq4u.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.76.186 X-Source-L: No X-Exim-ID: 1p5vnB-000lJm-JG X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-76-186.hlrn.qwest.net (murgatroyd) [97.122.76.186]:56994 X-Source-Auth: tom+tromey.com X-Email-Count: 4 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3022.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Bruno" == Bruno Larsen via Gdb-patches writes: Bruno> While chasing some reverse debugging bugs, I found myself wondering what Bruno> was recorded by GDB to undo and redo a certain instruction. This commit Bruno> implements a simple way of printing that information. Thanks. The idea seems fine to me. Bruno> + gdb_byte* b = record_full_get_loc (to_print); The "* " should be " *", there's a few of these. Bruno> + gdb_printf (" %02x",b[i]); Missing a space after the ",", also a few of these. Bruno> + add_cmd ("record-instruction", class_maintenance, Bruno> + maintenance_print_record_instruction, Bruno> + _("\ Bruno> +Print a recorded instruction.\nIf no argument is provided, print the last \ Bruno> +instruction recorded.\nIf a negative argument is given, prints how the nth \ Bruno> +previous instruction will be undone.\nIf a positive argument is given, prints \ Bruno> +how the nth following instruction will be redone."), &maintenanceprintlist); IMO it's better to end the lines with \n\ so that the line breaks are very clear when reading the text in the source. Tom