From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oa1-x34.google.com (mail-oa1-x34.google.com [IPv6:2001:4860:4864:20::34]) by sourceware.org (Postfix) with ESMTPS id CCAE738451A0 for ; Sat, 26 Nov 2022 01:50:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org CCAE738451A0 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-oa1-x34.google.com with SMTP id 586e51a60fabf-14286d5ebc3so6999081fac.3 for ; Fri, 25 Nov 2022 17:50:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:message-id:date:in-reply-to:subject:cc:to:from :user-agent:references:from:to:cc:subject:date:message-id:reply-to; bh=A0q4Vkx4UxEbWd3iz2jUglhDqVTMg3MSEt4ZUQyy12g=; b=pAFd5U+4iQ7MasxyN3nuzVk66iVJ2n9xI3T3XHDiZ7JGapP6vUsGitBXP9EILAZ+W3 IxoTJFqjG7SaJFHPCh8s/6NKL9wNPeS9gv4STY3O3xQmmEEWs2UsNbkdRZsY7dLavGaS MP2Dd5OjyxOZRtI9UIG/p8CafuDD/RbMVXosPD5lBF/trT7xHEfPVc4ltBNSGo+ndCkc M0TZW8JZ7nJxlnP8wKGr2DCY6sw8E9nzul/LkyKVGuy+3toqNZX2w8ouMgtFrukNLNzM TqpRLomWhPR7HN04Go4ouaCVSABAvCZ5v8Pnak+aDuAvpE8sq/WAYJv/cv3tltt45RqY vufw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:date:in-reply-to:subject:cc:to:from :user-agent:references:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=A0q4Vkx4UxEbWd3iz2jUglhDqVTMg3MSEt4ZUQyy12g=; b=o4lMPqE9Y92bX0vYyTyyjJcKjKjRUcb9DFriJV348a2ScosK2bThKnFr+NuDGzTSlJ C7IMnE4cN7ggr5UY35XdK7LSWIHdRjkvtTHBBWXxXkqCj0WdbDRTzwUZOErVkLYjvSrv lFMoyJoA3RrEbZUzlflzfT/ADVotsGORvXgZrlVBuLAKH8o3lSeiqITdwjHGFsXjZq1S My4iUqAJHXz1bxYoZL3wSXHrF8XvMf9qdYVi9cDI3INIGvavlfA7WoZ602ah/cppt28l 5q15LXLHPPmynAUpTavZBBxysH6oletJ/+k5bpGqsepy/zzsVVDN+X8BvWbSUPMARJPz oriA== X-Gm-Message-State: ANoB5pmdr16DdyLzUagFwQaKpDz+gB224WS1GTkPKIDlRx2s5HCtNCmz jdhM0a7RRueNKUPWty5UFGEOIGaZXhgsjQ== X-Google-Smtp-Source: AA0mqf7pxC287GnDOLSsztQ0lgbLZYX/n7rNiy+vPLMFwqIPPeesmzn/qRc66+ZiTI6Nmxc8Mvi0cw== X-Received: by 2002:a05:6870:6609:b0:13b:aa7d:b195 with SMTP id gf9-20020a056870660900b0013baa7db195mr15264133oab.19.1669427404095; Fri, 25 Nov 2022 17:50:04 -0800 (PST) Received: from localhost ([2804:14d:7e39:8470:41ee:c7fc:c991:eee6]) by smtp.gmail.com with ESMTPSA id f65-20020a9d2c47000000b00668953207b2sm2282383otb.80.2022.11.25.17.50.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Nov 2022 17:50:03 -0800 (PST) References: <20220908064151.3959930-1-thiago.bauermann@linaro.org> <20220908064151.3959930-9-thiago.bauermann@linaro.org> <36d5d17b-de17-71f9-06b8-46a31c450b4c@arm.com> User-agent: mu4e 1.8.11; emacs 28.2 From: Thiago Jung Bauermann To: Luis Machado Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 8/8] gdb/aarch64: When remote debugging detect changes in the target description In-reply-to: <36d5d17b-de17-71f9-06b8-46a31c450b4c@arm.com> Date: Sat, 26 Nov 2022 01:50:01 +0000 Message-ID: <87cz9a8oxi.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-4.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Luis Machado writes: > On 9/8/22 07:41, Thiago Jung Bauermann via Gdb-patches wrote: >> If the remote target provides an expedited VG register, use it to update >> its target description. This allows debugging programs that change their >> SVE vector length during runtime. >> This is accomplished by implementing the thread_architecture method in >> remote_target, which returns the gdbarch corresponding to the expedited >> registers provided by the last stop reply. >> To allow changing the architecture based on the expedited registers, add a >> new gdbarch method to allow arch-specific code to make the adjustment. >> --- >> gdb/aarch64-tdep.c | 28 +++++++++++++++++++++++++- >> gdb/arch-utils.c | 9 +++++++++ >> gdb/arch-utils.h | 5 +++++ >> gdb/gdbarch-components.py | 16 +++++++++++++++ >> gdb/gdbarch-gen.h | 11 ++++++++++ >> gdb/gdbarch.c | 23 +++++++++++++++++++++ >> gdb/remote.c | 42 +++++++++++++++++++++++++++++++++++++++ >> 7 files changed, 133 insertions(+), 1 deletion(-) > > LGTM for the aarch64 code. Someone else must approve the generic parts. Thank you again for your review. For v2 I changed the patch title and description a little bit, but the code is the same. -- Thiago