From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 403F6385840A for ; Mon, 24 Oct 2022 16:26:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 403F6385840A Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1666628762; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=II/r79KpGO6qRXVgIrxIKyd6EfHUJ4yMY/ESic6tAyA=; b=EVb+JPERa/D0NU9uWbwX1czNYEcKU0SOW0UULKTkaiTywNzbmeqGbM6a7bYm61NFmsmtFo 9X/DG/offnb+qoUfSjOODQ+JyyHz/VsaxiYeQys1+WgWc/WD0wNXnnhTBEgqTJVPa5h3w5 iYbCTHuciNITfL0spYVQgHGTWvrF9FA= Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-534-_R4fHTK0NCSJ2Rz0KWYCHQ-1; Mon, 24 Oct 2022 12:26:01 -0400 X-MC-Unique: _R4fHTK0NCSJ2Rz0KWYCHQ-1 Received: by mail-qt1-f197.google.com with SMTP id ga23-20020a05622a591700b0039ceee61202so7324279qtb.2 for ; Mon, 24 Oct 2022 09:26:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=II/r79KpGO6qRXVgIrxIKyd6EfHUJ4yMY/ESic6tAyA=; b=C4uV6Y5SV2WSmGeqUcdWzVVHW060uk2ZzWHsWi5mJaWkIS51YwhTgTAeFVcfzFkPKS zYpURYm414bSTosEwHEwRh5N5JSmNwN/v6LyboCcMIwJXkG0VJM/HblSMtjnzdssuSPV vOQcizRcB27xx4EXDXyXV2GHzRCUfITcdAd4rSfD0nDF1bMsJBQI4yQpgNTSUIf8v04Z U4rpZMHqQMtpPTtZmEfer0/AEEvOdfH2QXDLBXx8ad+WyfxPHvh3huF3gscD7E+WuL2k De2Jz/rXDufibaSOTZzuSuSAXFiSYY4kIEdltTPcRmswncOq99QgEEMi7bc8Qcsr/SEN QV2A== X-Gm-Message-State: ACrzQf3Xr9oWlbOY7gyjfXHs+XkG+OaJMS1ARwW5AQsudseFxSkUtGSi N4xm0TGnpvqTre23yLISEOb2K5zIfZyDTgbM5wbjWuM/8o+mGJPv4YaESBT2bGrB8P43nHxhHLt OgTjSGorRXTE4CzF8y7ab0A== X-Received: by 2002:ac8:574f:0:b0:39c:bbef:1781 with SMTP id 15-20020ac8574f000000b0039cbbef1781mr28456165qtx.163.1666628760969; Mon, 24 Oct 2022 09:26:00 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7qfs8+o0SagRGD8pqHNwwrJsjvSipwfHkcn7xGi0E4mgfhJ45MdJTcnmY0ZM3pQj1nDhjX8Q== X-Received: by 2002:ac8:574f:0:b0:39c:bbef:1781 with SMTP id 15-20020ac8574f000000b0039cbbef1781mr28456156qtx.163.1666628760760; Mon, 24 Oct 2022 09:26:00 -0700 (PDT) Received: from localhost ([31.111.84.238]) by smtp.gmail.com with ESMTPSA id br17-20020a05620a461100b006e9b3096482sm217174qkb.64.2022.10.24.09.26.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Oct 2022 09:26:00 -0700 (PDT) From: Andrew Burgess To: Mike Frysinger Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 03/10] sim/ppc: initialize a memory buffer in all cases In-Reply-To: References: <0bd7df35b8c709a72d6f2a0900e60fa12727779e.1666192979.git.aburgess@redhat.com> Date: Mon, 24 Oct 2022 17:25:58 +0100 Message-ID: <87czah89yh.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-5.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Mike Frysinger writes: > On 19 Oct 2022 16:24, Andrew Burgess via Gdb-patches wrote: >> --- a/sim/ppc/emul_netbsd.c >> +++ b/sim/ppc/emul_netbsd.c >> @@ -888,6 +888,8 @@ do_fstat(os_emul_data *emul, >> status = fdbad (fd); >> if (status == 0) >> status = fstat(fd, &buf); >> + else >> + memset (&buf, 0, sizeof (buf)); > > i don't think this is perf critical, so simpler to do: > struct statfs buf = {}; Pushed with the fix you suggest. Thanks, Andrew