From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gproxy4-pub.mail.unifiedlayer.com (gproxy4-pub.mail.unifiedlayer.com [69.89.23.142]) by sourceware.org (Postfix) with ESMTPS id 8CE453858D38 for ; Fri, 14 Oct 2022 17:56:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 8CE453858D38 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw11.mail.unifiedlayer.com (unknown [10.0.90.126]) by progateway6.mail.pro1.eigbox.com (Postfix) with ESMTP id C2B2B100463A2 for ; Fri, 14 Oct 2022 17:56:44 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id jOvLoaLVFj36OjOvMoGiHw; Fri, 14 Oct 2022 17:56:44 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=T89J89GQ c=1 sm=1 tr=0 ts=6349a2dc a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=Qawa6l4ZSaYA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=CCpqsmhAAAAA:8 a=75FAf6A6GYzAqeeAwkAA:9 a=66zSKFQpzMcA:10:demote_shortener_domain_2 a=ul9cdbp4aOFLsgKbc677:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=EbQmaejcM9MvahspTxZ/xklLJ9a3b+fIf+hmYSjMo1c=; b=gvVF0NKX3Z4tK3UUSEpaLVWEZx PqWWc/4SsIHAV9HCtVDgq1Gi4qvHKlykU195cQp85+NftEYHAVGkXoHTb58MEPW9XcV563BwvOYGQ A82REwe/Ehz4rfir6ECIzxPF3; Received: from 71-211-160-49.hlrn.qwest.net ([71.211.160.49]:56684 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1ojOvL-004EkA-DS; Fri, 14 Oct 2022 11:56:43 -0600 From: Tom Tromey To: Tom de Vries via Gdb-patches Cc: Tom de Vries Subject: Re: [PATCH][gdb] Fix heap-buffer-overflow in find_program_interpreter References: <20221012154131.GA24693@delia.home> X-Attribution: Tom Date: Fri, 14 Oct 2022 11:56:38 -0600 In-Reply-To: <20221012154131.GA24693@delia.home> (Tom de Vries via Gdb-patches's message of "Wed, 12 Oct 2022 17:41:33 +0200") Message-ID: <87czaumgq1.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 71.211.160.49 X-Source-L: No X-Exim-ID: 1ojOvL-004EkA-DS X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 71-211-160-49.hlrn.qwest.net (murgatroyd) [71.211.160.49]:56684 X-Source-Auth: tom+tromey.com X-Email-Count: 13 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3022.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 Oct 2022 17:57:00 -0000 >>>>> "Tom" == Tom de Vries via Gdb-patches writes: Tom> The problem originates in find_program_interpreter, where Tom> bfd_get_section_contents is called to read .interp, but fails. The function Tom> returns false but the result is ignored, so find_program_interpreter returns Tom> some random string. Tom> Fix this by checking the result of the call to bfd_get_section_contents. Tom> Tested on x86_64-linux. Tom> Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=29652 Tom> Any comments? Looks good, thank you. Tom