From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io1-xd2b.google.com (mail-io1-xd2b.google.com [IPv6:2607:f8b0:4864:20::d2b]) by sourceware.org (Postfix) with ESMTPS id 02B00385828D for ; Fri, 22 Jul 2022 19:16:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 02B00385828D Received: by mail-io1-xd2b.google.com with SMTP id p81so4343804iod.2 for ; Fri, 22 Jul 2022 12:16:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=ffDFLJyK31WISqzbbGvi1WT/5BON1oEXJk8eCUjJurk=; b=0sltytcIJFTRQtL0qAv7VvjNn+lgf6gDurDl8iMtwT5ZsE8UKDzW1/duTlfBWXpvPa /WvkgYpUuFUUPzNoQflSyQR7U7DI1/w/ZbMOIWr9sFuK6I80/4K706yBjdMUm497JAVP vzYhlrALtSgjTT4WwUY3rDZZ+viclCIhV8oB6akXlmnz0v+YfN6KDBl4Zaq9iWjy/d4Z MLKJWQRsDNCR0FV1NIZOlH+pW66yfwS297jCrlmbCOAgvy6wo9EVahntetCIVU6xsB7j 9tVOkX4JInnBvfGYk0sR1JpYmxRBq1RV+0416zC1uXItseKE895WiqcXwRDVpJmNe2YT nUog== X-Gm-Message-State: AJIora+nDC/RfLgpK8IQHMofCTEZV8Mm48Ipr0r8BqIPPzjzS/AfJq5q CM17+bL4hPhac03O4OWxmmMfTw== X-Google-Smtp-Source: AGRyM1u9Y8IMLEmrJfnzAVHskds1keCiD0TvUQHJRqKh+bI0WiQbHXtMsAZXNrVOzrdt+xIPtAyocw== X-Received: by 2002:a05:6638:134e:b0:341:4260:1742 with SMTP id u14-20020a056638134e00b0034142601742mr697244jad.131.1658517409776; Fri, 22 Jul 2022 12:16:49 -0700 (PDT) Received: from murgatroyd (71-211-185-228.hlrn.qwest.net. [71.211.185.228]) by smtp.gmail.com with ESMTPSA id r19-20020a0566022b9300b00678ea668a39sm2462452iov.36.2022.07.22.12.16.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Jul 2022 12:16:49 -0700 (PDT) From: Tom Tromey To: Simon Marchi via Gdb-patches Subject: Re: [PATCH] gdb/testsuite: give binaries distinct names in Ada tests References: <20220719171417.3651000-1-simon.marchi@polymtl.ca> X-Attribution: Tom Date: Fri, 22 Jul 2022 13:16:48 -0600 In-Reply-To: <20220719171417.3651000-1-simon.marchi@polymtl.ca> (Simon Marchi via Gdb-patches's message of "Tue, 19 Jul 2022 13:14:16 -0400") Message-ID: <87czdxj6u7.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-4.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Jul 2022 19:16:57 -0000 >>>>> "Simon" == Simon Marchi via Gdb-patches writes: Simon> Some Ada tests repeat their test sequence with different gnat-encodings, Simon> typically "all" and "minimal". However, they give the same name to both Simon> binaries, meaning the second run overwrites the binary of the first run. Simon> This makes it difficult and confusing when trying to reproduce problems Simon> manually with the test artifacts. Change those tests to use unique Simon> names for each pass. Seems like a good idea. Thank you for doing this. Tom