From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from alt-proxy28.mail.unifiedlayer.com (alt-proxy28.mail.unifiedlayer.com [74.220.216.123]) by sourceware.org (Postfix) with ESMTPS id 59628384D140 for ; Fri, 15 Jul 2022 20:20:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 59628384D140 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw12.mail.unifiedlayer.com (unknown [10.0.90.127]) by progateway1.mail.pro1.eigbox.com (Postfix) with ESMTP id B72FF10040437 for ; Fri, 15 Jul 2022 20:20:16 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id CRnMoy051Wg0ECRnMoyq3v; Fri, 15 Jul 2022 20:20:16 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=Y4w9DjSN c=1 sm=1 tr=0 ts=62d1cc00 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=RgO8CyIxsXoA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=CCpqsmhAAAAA:8 a=wUoBifYKVU5KGfaUbg0A:9 a=ul9cdbp4aOFLsgKbc677:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=PZJKASQ/f/+NlOG4obhuJ9b8ceTEP6aYVThIN9KFR+o=; b=bK3XXGCpAtpbqeySijgpOgyUM2 OPTEz2raykgZcKy2GRnXdxYI4vIy+XedV1j2C80V2s0l/6C5Lv4u8sbOOC09ivGH2XVJ64szYK8VI iGG+bClgFCj8CjgiJ+x/RohZ2; Received: from 71-211-185-228.hlrn.qwest.net ([71.211.185.228]:56140 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1oCRnM-000r9F-2B; Fri, 15 Jul 2022 14:20:16 -0600 From: Tom Tromey To: Nils-Christian Kempke via Gdb-patches Subject: Re: [PATCH 3/3] gdb/infrun: handle stepping through functions with DW_AT_trampoline References: <20220707121538.1317473-2-nils-christian.kempke@intel.com> <20220707121538.1317473-4-nils-christian.kempke@intel.com> X-Attribution: Tom Date: Fri, 15 Jul 2022 14:20:15 -0600 In-Reply-To: <20220707121538.1317473-4-nils-christian.kempke@intel.com> (Nils-Christian Kempke via Gdb-patches's message of "Thu, 7 Jul 2022 14:15:38 +0200") Message-ID: <87cze6m8lc.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 71.211.185.228 X-Source-L: No X-Exim-ID: 1oCRnM-000r9F-2B X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 71-211-185-228.hlrn.qwest.net (murgatroyd) [71.211.185.228]:56140 X-Source-Auth: tom+tromey.com X-Email-Count: 5 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3022.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 Jul 2022 20:20:31 -0000 >>>>> Nils-Christian Kempke via Gdb-patches writes: > This patch makes infrun continue stepping into and through trampoline > functions marked via the DW_AT_trampoline in DWARF. The attribute can > be emitted by the compiler for certain subroutines/inlined subroutines > that are compiler generated and should be hidden from a user. Thank you for the patch. I don't really know enough about infrun to comment on most of this patch. It seems like a good idea to me. It's close to a feature users have wanted for a while -- an addition to the "skip" command to skip through library-provided wrappers. > + add_setshow_boolean_cmd ("skip-trampoline-functions", class_run, > + &skip_trampoline_functions, _("\ > +Set whether gdb attempts to hide trampolines marked in the debug info."), _("\ > +Show whether gdb attempts to hide trampolines marked in the debug info."), _("\ > +If on, while stepping gdb will skip through function trampolines and inlined\n\ > +fucntion trampolines that have been marked trampolines in the compiler's\n\ Typo, "function". Also maybe "marked as trampolines by the compiler" instead. > +debug info. If off, gdb will ignore the DW_TAG_trampoline while stepping."), I think this should probably not refer to DW_TAG_trampoline. Few users will understand this. thanks, Tom