From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi1-x234.google.com (mail-oi1-x234.google.com [IPv6:2607:f8b0:4864:20::234]) by sourceware.org (Postfix) with ESMTPS id 5628F3858D28 for ; Mon, 25 Apr 2022 20:07:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 5628F3858D28 Received: by mail-oi1-x234.google.com with SMTP id e189so18378071oia.8 for ; Mon, 25 Apr 2022 13:07:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:references:user-agent:from:to:cc:subject:date :in-reply-to:message-id:mime-version; bh=U159H0GeyRYh4L6dTds1oe64QyrE5dw7xhvihozXty8=; b=m/uAh6DzU9FzhHnKRYvdGrHiaBN6nAYYyIb3hXznsc/Rvh3zj0nxjnAKlf89j05hy3 cH7Mfbqs4c8NHYtQVJuWR/2e+Rlu77Rjhew9dYkT5O0NQk+k95A0WhzculwubgnzQO1U naFOHNJfx8OJo6j9e1HjkHyZNQReSo/eCaN4KO+Kta79Q6qO/R3nBcj2aSBK6IvWBY/Z FggYdg1LWGfrWelZoDuKI5PzZmpkVgNk8Oyn7kL0E5n9fKNg8ugLrTRWIXchBY88uRjL VVRefvZPPGht1MHqALiwaIKw3Gh9OGF/d+dn4drTxyB0sWfhXBaajMZwCxUDGgdYGo3S pkmQ== X-Gm-Message-State: AOAM532y3YZw0wfYnFYFjpxMDATLvqZxPTmX01Wd24hv9xrcjmNRHdEv dcE7OYpkY8OsDBe74HaGLEBlxQ== X-Google-Smtp-Source: ABdhPJyobHeLa0iOVtWr4X8KvBHyp++irYn9TBjWcapEf6cOOSA+8NxiBtlW0z2JyUCUPGmu/yDfiQ== X-Received: by 2002:a05:6808:1115:b0:2ec:e103:99c8 with SMTP id e21-20020a056808111500b002ece10399c8mr8914410oih.194.1650917268760; Mon, 25 Apr 2022 13:07:48 -0700 (PDT) Received: from localhost ([2804:14d:7e39:8470:cb90:8084:f534:54ff]) by smtp.gmail.com with ESMTPSA id u20-20020a4a9e94000000b003291f6ac4b2sm4768250ook.28.2022.04.25.13.07.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Apr 2022 13:07:48 -0700 (PDT) References: <20220118194007.2853108-1-tom@tromey.com> <20220118194007.2853108-5-tom@tromey.com> <87h76h8d8l.fsf@linaro.org> <87levt7zjr.fsf@tromey.com> User-agent: mu4e 1.6.10; emacs 27.2 From: Thiago Jung Bauermann To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 04/36] Delete some unnecessary wrapper functions Date: Mon, 25 Apr 2022 17:06:01 -0300 In-reply-to: <87levt7zjr.fsf@tromey.com> Message-ID: <87czh57wq7.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 Apr 2022 20:07:52 -0000 Hello Tom, Tom Tromey writes: >>>>>> "Thiago" == Thiago Jung Bauermann writes: > > Thiago> The wrapper here does an std::move() of the string arguments. > > Yeah. That's needed because std::unique_ptr is move-only. > > Thiago> So shouldn't the callers of ops->create_breakpoints_sal () be changed to > Thiago> do the std::move() themselves? > > I think there's only one, and it does: > > ops->create_breakpoints_sal (gdbarch, &canonical, > std::move (cond_string_copy), > std::move (extra_string_copy), > type_wanted, > tempflag ? disp_del : disp_donttouch, > thread, task, ignore_count, ops, > from_tty, enabled, internal, flags); Yes, you are right. Sorry for the noise. -- Thiago