From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from qproxy4-pub.mail.unifiedlayer.com (qproxy4-pub.mail.unifiedlayer.com [66.147.248.250]) by sourceware.org (Postfix) with ESMTPS id A4AAF3858C53 for ; Mon, 4 Apr 2022 16:52:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A4AAF3858C53 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from outbound-ss-761.bluehost.com (outbound-ss-761.bluehost.com [74.220.211.250]) by qproxy4.mail.unifiedlayer.com (Postfix) with ESMTP id DCEE1803A3BC for ; Mon, 4 Apr 2022 16:52:46 +0000 (UTC) Received: from cmgw11.mail.unifiedlayer.com (unknown [10.0.90.126]) by progateway8.mail.pro1.eigbox.com (Postfix) with ESMTP id 7FE4310112BC6 for ; Mon, 4 Apr 2022 16:52:16 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id bPw8nmz7mwm8ibPw8noUQa; Mon, 04 Apr 2022 16:52:16 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=DpSTREz+ c=1 sm=1 tr=0 ts=624b2240 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=z0gMJWrwH1QA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=CCpqsmhAAAAA:8 a=ko-RNVO-HouC8rAfIWkA:9 a=ul9cdbp4aOFLsgKbc677:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=FC5g1rYXtqFw6OuFvTMSXQNpmczDTTT4TI+gOc4F1zE=; b=w9Bqu+gz3Cqt/DsANOYc9jOT6X tCzj0o5+Qyoh7iQfhSIZZGujQeeYqT262jLH0XUAVnpk0VOTf/6FguLMSubr9qOjpffUkKiFPt5PW OUENB9fKRzsUXPy16UuhaiPU4; Received: from 71-211-176-135.hlrn.qwest.net ([71.211.176.135]:55390 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nbPw7-00126Y-NQ; Mon, 04 Apr 2022 10:52:15 -0600 From: Tom Tromey To: Simon Marchi via Gdb-patches Subject: Re: [PATCH] gdb: make timestamped_file implement can_emit_style_escape References: <20220331173220.2536607-1-simon.marchi@polymtl.ca> X-Attribution: Tom Date: Mon, 04 Apr 2022 10:52:15 -0600 In-Reply-To: <20220331173220.2536607-1-simon.marchi@polymtl.ca> (Simon Marchi via Gdb-patches's message of "Thu, 31 Mar 2022 13:32:20 -0400") Message-ID: <87czhwkczk.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 71.211.176.135 X-Source-L: No X-Exim-ID: 1nbPw7-00126Y-NQ X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 71-211-176-135.hlrn.qwest.net (murgatroyd) [71.211.176.135]:55390 X-Source-Auth: tom+tromey.com X-Email-Count: 7 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3024.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 Apr 2022 16:52:48 -0000 >>>>> "Simon" == Simon Marchi via Gdb-patches writes: Simon> In our AMDGPU downstream port, we use styling in some logging output. Simon> We noticed it stopped working after the gdb_printf changes. Sorry about that. Simon> Making Simon> timestamped_file implement can_emit_style_escape (returning the value of Simon> the stream it wraps) fixes it. To show that it works, modify some Simon> logging statements in auto-load.c to output style filenames. You can Simon> see it in action by setting "set debug auto-load 1" and running a Simon> program. We can incrementally add styling to other debug statements Simon> throughout GDB, as needed. This looks good to me. I've also wondered what it would take to style error() text. Maybe just checking the styling of gdb_stdout when creating the error would be good enough, it's not like gdb often stores exceptions and then later reuses them. Another thought was to have styling always be emitted, then optionally strip it out just before display. However, user 'printf's can also emit styles and one wouldn't want to strip those... Tom