From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from outbound-ss-761.bluehost.com (outbound-ss-761.bluehost.com [74.220.211.250]) by sourceware.org (Postfix) with ESMTPS id 74BA33858D20 for ; Thu, 17 Feb 2022 23:59:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 74BA33858D20 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw10.mail.unifiedlayer.com (unknown [10.0.90.125]) by progateway8.mail.pro1.eigbox.com (Postfix) with ESMTP id C86B8100612AD for ; Thu, 17 Feb 2022 23:59:09 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id Kqg1n6O2dnAlUKqg1n05p5; Thu, 17 Feb 2022 23:59:09 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=QIOt+iHL c=1 sm=1 tr=0 ts=620ee14d a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=oGFeUVbbRNcA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=CCpqsmhAAAAA:8 a=8t6OcJO_z-aqqbK7OwQA:9 a=ul9cdbp4aOFLsgKbc677:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=fJn6kWMxK4MpGluuuJSuykfkAA8lNurt0AqwwDSfUQ0=; b=N5nKsD7+zOquJr/tI6x9tSyaHH GzBgmQqAYYV7+vOt4D3DH3dtYbTGe9+u1ic6EhZ5Vcg6D1KzaN7DqkyYVEReTnmpBkhXCy8XY/gwz vgGY1bjaeBbK7SSgQYsc2g7R6; Received: from c-73-181-19-44.hsd1.co.comcast.net ([73.181.19.44]:46124 helo=prentzel) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nKqg0-0005zt-Vv; Thu, 17 Feb 2022 16:59:09 -0700 From: Tom Tromey To: Lancelot SIX via Gdb-patches Cc: Lancelot SIX , lsix@lancelotsix.com Subject: Re: [PATCH] gdb: Only paginate for filtered output in fputs_maybe_filtered References: <20220217111904.3623848-1-lancelot.six@amd.com> X-Attribution: Tom Date: Thu, 17 Feb 2022 16:59:08 -0700 In-Reply-To: <20220217111904.3623848-1-lancelot.six@amd.com> (Lancelot SIX via Gdb-patches's message of "Thu, 17 Feb 2022 11:19:04 +0000") Message-ID: <87czjloxir.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 73.181.19.44 X-Source-L: No X-Exim-ID: 1nKqg0-0005zt-Vv X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: c-73-181-19-44.hsd1.co.comcast.net (prentzel) [73.181.19.44]:46124 X-Source-Auth: tom+tromey.com X-Email-Count: 12 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3025.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 Feb 2022 23:59:15 -0000 >>>>> ">" == Lancelot SIX via Gdb-patches writes: >> The filter parameter is correctly used to guard the first place where >> prompt_for_continue. There is a second place in the function which can call >> prompt_for_continue, but is currently unguarded. I believe that this is an >> oversight, this patch fixes that. Thanks, this is ok. It's perhaps worth noting that I believe this is also fixed by my series to change the filter to be a more ordinary ui_file. Tom