From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gateway31.websitewelcome.com (gateway31.websitewelcome.com [192.185.143.47]) by sourceware.org (Postfix) with ESMTPS id 007BD3858C2C for ; Thu, 30 Sep 2021 17:48:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 007BD3858C2C Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tromey.com Received: from cm12.websitewelcome.com (cm12.websitewelcome.com [100.42.49.8]) by gateway31.websitewelcome.com (Postfix) with ESMTP id 94B3635419 for ; Thu, 30 Sep 2021 12:48:09 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id W0ADm6lpgOnCIW0ADmggxD; Thu, 30 Sep 2021 12:48:09 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=XRbOer5TotNO9KVTeP6y6UzQqF+9zjl0BOpxR24p4ss=; b=GppPiWzr0xlRnWZxmfTg4qwxJh m6KP9Bjqm2HxtDY+7Ho1TXKGYvqPUoGBhPRz86IwloM66DTSphTo5GeKMvz1okl5KdbfriLTnd/8z 85BjgJsX2S9JndYPHKeUo6vvU; Received: from 174-16-0-219.hlrn.qwest.net ([174.16.0.219]:53934 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1mW0AD-000luw-6N; Thu, 30 Sep 2021 11:48:09 -0600 From: Tom Tromey To: Simon Marchi via Gdb-patches Cc: Tom Tromey , Simon Marchi Subject: Re: [PATCH 1/3] gdbsupport: change scoped_fd::to_file to a free function References: <20210722193714.1778717-1-simon.marchi@polymtl.ca> <87r1ff9anc.fsf@tromey.com> <509cd9b9-48d4-a9fe-31c9-05a8b66b4dee@polymtl.ca> X-Attribution: Tom Date: Thu, 30 Sep 2021 11:48:08 -0600 In-Reply-To: <509cd9b9-48d4-a9fe-31c9-05a8b66b4dee@polymtl.ca> (Simon Marchi via Gdb-patches's message of "Thu, 30 Sep 2021 12:17:47 -0400") Message-ID: <87czoq0xbb.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 174.16.0.219 X-Source-L: No X-Exim-ID: 1mW0AD-000luw-6N X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 174-16-0-219.hlrn.qwest.net (murgatroyd) [174.16.0.219]:53934 X-Source-Auth: tom+tromey.com X-Email-Count: 8 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3025.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_NEUTRAL, TXREP autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Sep 2021 17:48:15 -0000 >>>>> "Simon" == Simon Marchi via Gdb-patches writes: Simon> But I agree with you here. See the updated 1/3 patch below. Looks good to me, thank you. Tom