From: Tom Tromey <tom@tromey.com>
To: Tankut Baris Aktemur via Gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH 1/6] gdb/infcmd: remove the unused parameter 'args' in 'attach_post_wait'
Date: Wed, 21 Apr 2021 13:24:59 -0600 [thread overview]
Message-ID: <87czunbfuc.fsf@tromey.com> (raw)
In-Reply-To: <0013ebfdeb103a5142264bf02fc7abc4628a572a.1619009681.git.tankut.baris.aktemur@intel.com> (Tankut Baris Aktemur via Gdb-patches's message of "Wed, 21 Apr 2021 14:57:26 +0200")
>>>>> ">" == Tankut Baris Aktemur via Gdb-patches <gdb-patches@sourceware.org> writes:
>> gdb/ChangeLog:
>> 2021-04-21 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
>> * infcmd.c (attach_post_wait): Remove the unused parameter 'args'.
>> Update the references below.
>> (struct attach_command_continuation_args)
>> (attach_command_continuation)
>> (attach_command_continuation_free_args)
>> (attach_command)
>> (notice_new_inferior): Update to remove the reference to 'args'.
Normally it's good to have some text in the body that explains the
commit.
The patch is ok though.
thank you,
Tom
next prev parent reply other threads:[~2021-04-21 19:26 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-21 12:57 [PATCH 0/6] Refactoring around inferior continuations Tankut Baris Aktemur
2021-04-21 12:57 ` [PATCH 1/6] gdb/infcmd: remove the unused parameter 'args' in 'attach_post_wait' Tankut Baris Aktemur
2021-04-21 19:24 ` Tom Tromey [this message]
2021-04-21 19:32 ` Simon Marchi
2021-04-21 19:47 ` Tom Tromey
2021-04-22 5:57 ` Aktemur, Tankut Baris
2021-04-21 12:57 ` [PATCH 2/6] gdb/infcmd: update the comment for 'attach_post_wait' Tankut Baris Aktemur
2021-04-21 19:25 ` Tom Tromey
2021-04-21 12:57 ` [PATCH 3/6] gdb/continuations: remove the 'err' from 'do_all_inferior_continuations' Tankut Baris Aktemur
2021-04-21 19:29 ` Tom Tromey
2021-04-21 12:57 ` [PATCH 4/6] gdb/continuations: do minor cleanup Tankut Baris Aktemur
2021-04-21 19:31 ` Tom Tromey
2021-04-21 12:57 ` [PATCH 5/6] gdb/continuations: use lambdas instead of function pointers Tankut Baris Aktemur
2021-04-21 19:43 ` Tom Tromey
2021-04-22 7:49 ` Aktemur, Tankut Baris
2021-04-22 12:50 ` Tom Tromey
2021-04-22 14:07 ` Aktemur, Tankut Baris
2021-04-22 14:12 ` Tom Tromey
2021-04-21 12:57 ` [PATCH 6/6] gdb/continuations: turn continuation functions into inferior methods Tankut Baris Aktemur
2021-04-21 19:46 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87czunbfuc.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).