From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gateway32.websitewelcome.com (gateway32.websitewelcome.com [192.185.145.101]) by sourceware.org (Postfix) with ESMTPS id 8DC5D3857023 for ; Fri, 28 Aug 2020 19:25:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 8DC5D3857023 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tom@tromey.com Received: from cm11.websitewelcome.com (cm11.websitewelcome.com [100.42.49.5]) by gateway32.websitewelcome.com (Postfix) with ESMTP id BFE66AF52 for ; Fri, 28 Aug 2020 14:25:30 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id Bk0Akziw2OIGpBk0AkY52c; Fri, 28 Aug 2020 14:25:30 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Zj7DHRxs8t7ZGHWo+rKp3uv/SzDqwlqFr6sxa1rFHck=; b=NDGF1OZd0PBVzZ75virx4zpwwH 7RjfL0yoFIof/TcePKG//m9bVtQizggc4yAwpG8G1eG8lnZctlD+fczuV8QFSUmS6jDQfJbLynD5G RrpSDRZUbNJlc8CqmpfSUd08I; Received: from 71-218-12-75.hlrn.qwest.net ([71.218.12.75]:40432 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1kBk0A-003zVC-Ey; Fri, 28 Aug 2020 13:25:30 -0600 From: Tom Tromey To: Simon Marchi Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH 01/13] Add a new overload of gdb_bfd_sections References: <20200828162349.987-1-tom@tromey.com> <20200828162349.987-2-tom@tromey.com> <7023e3ad-0200-9eaa-4a77-191b1cc5f567@simark.ca> X-Attribution: Tom Date: Fri, 28 Aug 2020 13:25:29 -0600 In-Reply-To: <7023e3ad-0200-9eaa-4a77-191b1cc5f567@simark.ca> (Simon Marchi's message of "Fri, 28 Aug 2020 12:34:10 -0400") Message-ID: <87d03a8tee.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 71.218.12.75 X-Source-L: No X-Exim-ID: 1kBk0A-003zVC-Ey X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 71-218-12-75.hlrn.qwest.net (bapiya) [71.218.12.75]:40432 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3027.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_ABUSEAT, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS, SPF_NEUTRAL, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 28 Aug 2020 19:25:34 -0000 Simon> Ah thanks for fixing the formatting. I'm confusing different styles for Simon> different code bases I'm working with at the moment :). It's definitely a pain when you work on more than one code base. That happened to me when I was at Moz. Actually the Moz tree itself had two different styles, which as you can imagine is impossible to get right. >> +static inline gdb_bfd_section_range >> +gdb_bfd_sections (const gdb_bfd_ref_ptr &abfd) >> +{ >> + return gdb_bfd_section_range (abfd->sections); >> +}; >> + Simon> Just to confirm, the point of this is to avoid having to do `.get Simon> ()` everywhere? Yeah, it is just a convenience for exactly that reason. Tom