* [PATCH] Enable hardware breakpoints for gdbserver on Windows [not found] <20200511174241.4288-1-ssbssa.ref@yahoo.de> @ 2020-05-11 17:42 ` Hannes Domani 2020-05-14 19:11 ` Tom Tromey 0 siblings, 1 reply; 3+ messages in thread From: Hannes Domani @ 2020-05-11 17:42 UTC (permalink / raw) To: gdb-patches When trying to use hardware breakpoints with gdbserver you get this error: (gdb) hbreak main Hardware assisted breakpoint 2 at 0x40162d: file gdb-9493.c, line 5. (gdb) c Continuing. Warning: Cannot insert hardware breakpoint 2. Could not insert hardware breakpoints: You may have requested too many hardware breakpoints/watchpoints. It turns out the respective types just needed to be added to the appropriate callback functions, because x86_dr_(insert|remove)_watchpoint already handles them. gdbserver/ChangeLog: 2020-05-11 Hannes Domani <ssbssa@yahoo.de> * win32-i386-low.cc (i386_supports_z_point_type): Handle Z_PACKET_HW_BP z_type. (i386_insert_point): Handle raw_bkpt_type type. (i386_remove_point): Likewise. --- gdbserver/win32-i386-low.cc | 3 +++ 1 file changed, 3 insertions(+) diff --git a/gdbserver/win32-i386-low.cc b/gdbserver/win32-i386-low.cc index 389ec49284..410f10a7c2 100644 --- a/gdbserver/win32-i386-low.cc +++ b/gdbserver/win32-i386-low.cc @@ -162,6 +162,7 @@ i386_supports_z_point_type (char z_type) { switch (z_type) { + case Z_PACKET_HW_BP: case Z_PACKET_WRITE_WP: case Z_PACKET_ACCESS_WP: return 1; @@ -176,6 +177,7 @@ i386_insert_point (enum raw_bkpt_type type, CORE_ADDR addr, { switch (type) { + case raw_bkpt_type_hw: case raw_bkpt_type_write_wp: case raw_bkpt_type_access_wp: { @@ -197,6 +199,7 @@ i386_remove_point (enum raw_bkpt_type type, CORE_ADDR addr, { switch (type) { + case raw_bkpt_type_hw: case raw_bkpt_type_write_wp: case raw_bkpt_type_access_wp: { -- 2.26.2 ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Enable hardware breakpoints for gdbserver on Windows 2020-05-11 17:42 ` [PATCH] Enable hardware breakpoints for gdbserver on Windows Hannes Domani @ 2020-05-14 19:11 ` Tom Tromey 2020-05-15 8:57 ` Hannes Domani 0 siblings, 1 reply; 3+ messages in thread From: Tom Tromey @ 2020-05-14 19:11 UTC (permalink / raw) To: Hannes Domani via Gdb-patches >>>>> "Hannes" == Hannes Domani via Gdb-patches <gdb-patches@sourceware.org> writes: Hannes> 2020-05-11 Hannes Domani <ssbssa@yahoo.de> Hannes> * win32-i386-low.cc (i386_supports_z_point_type): Handle Hannes> Z_PACKET_HW_BP z_type. Hannes> (i386_insert_point): Handle raw_bkpt_type type. Hannes> (i386_remove_point): Likewise. Looks good to me. Thank you. Tom ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Enable hardware breakpoints for gdbserver on Windows 2020-05-14 19:11 ` Tom Tromey @ 2020-05-15 8:57 ` Hannes Domani 0 siblings, 0 replies; 3+ messages in thread From: Hannes Domani @ 2020-05-15 8:57 UTC (permalink / raw) To: Gdb-patches Am Donnerstag, 14. Mai 2020, 21:11:10 MESZ hat Tom Tromey <tom@tromey.com> Folgendes geschrieben: > >>>>> "Hannes" == Hannes Domani via Gdb-patches <gdb-patches@sourceware.org> writes: > > Hannes> 2020-05-11 Hannes Domani <ssbssa@yahoo.de> > > Hannes> * win32-i386-low.cc (i386_supports_z_point_type): Handle > Hannes> Z_PACKET_HW_BP z_type. > Hannes> (i386_insert_point): Handle raw_bkpt_type type. > Hannes> (i386_remove_point): Likewise. > > Looks good to me. > Thank you. Pushed, thanks. Btw, is there no longer an automatic date update of bfd/version.h? Hannes ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-05-15 8:57 UTC | newest] Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- [not found] <20200511174241.4288-1-ssbssa.ref@yahoo.de> 2020-05-11 17:42 ` [PATCH] Enable hardware breakpoints for gdbserver on Windows Hannes Domani 2020-05-14 19:11 ` Tom Tromey 2020-05-15 8:57 ` Hannes Domani
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).