From: Tom Tromey <tom@tromey.com>
To: Andrew Burgess <andrew.burgess@embecosm.com>
Cc: gdb-patches@sourceware.org, richard.bunt@arm.com
Subject: Re: [PATCH] gdb/testsuite/fortran: Add mixed language stack test
Date: Thu, 12 Mar 2020 12:17:52 -0600 [thread overview]
Message-ID: <87d09hjv3j.fsf@tromey.com> (raw)
In-Reply-To: <20200305210911.23478-1-andrew.burgess@embecosm.com> (Andrew Burgess's message of "Thu, 5 Mar 2020 21:09:11 +0000")
>>>>> "Andrew" == Andrew Burgess <andrew.burgess@embecosm.com> writes:
Andrew> This commit adds a test that builds a mixed language stack, the stack
Andrew> contains frames of Fortran, C, and C++. The test prints the backtrace
Andrew> and explores the stack printing arguments of different types in frames
Andrew> of different languages.
Andrew> The core of the test is repeated with GDB's language set to auto,
Andrew> fortran, c, and c++ in turn to ensure that GDB is happy to print
Andrew> frames and frame arguments when the language is set to a value that
Andrew> doesn't match the frame language.
Andrew> This test currently passes, and there are no known bugs in this area.
Andrew> The aim of this commit is simply to increase test coverage, as I don't
Andrew> believe this functionality is currently tested.
This seems like a good idea to me.
The patch looked fine as well.
Thank you for doing this.
Tom
next prev parent reply other threads:[~2020-03-12 18:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-05 21:09 Andrew Burgess
2020-03-12 18:17 ` Tom Tromey [this message]
2020-03-20 14:53 ` Tom de Vries
2020-03-23 12:05 ` Andrew Burgess
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d09hjv3j.fsf@tromey.com \
--to=tom@tromey.com \
--cc=andrew.burgess@embecosm.com \
--cc=gdb-patches@sourceware.org \
--cc=richard.bunt@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).