From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gateway20.websitewelcome.com (gateway20.websitewelcome.com [192.185.61.9]) by sourceware.org (Postfix) with ESMTPS id 86E3B387700D for ; Thu, 12 Mar 2020 18:17:54 +0000 (GMT) Received: from cm17.websitewelcome.com (cm17.websitewelcome.com [100.42.49.20]) by gateway20.websitewelcome.com (Postfix) with ESMTP id 51A47400D4A78 for ; Thu, 12 Mar 2020 12:02:47 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id CSP3jmdvKAGTXCSP3jDsWz; Thu, 12 Mar 2020 13:17:53 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=qPoupJ8FI0UgffDZEzpkJMrtImuuY2GM3NxmS19SDO4=; b=uyMPqCUWwYKbaZVv1IpS8qNeQs mVV8+D/ugAA8Q7zrTc2YWsPhjpwQxZLGH/LIXjo0UpIhckSE1si/U/I2vT2t7TXPSx72CcCDlQZN3 ph6dy/yv4eQdM8c1KyufEpCZ5; Received: from 184-96-250-69.hlrn.qwest.net ([184.96.250.69]:60540 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1jCSP3-001hsu-LE; Thu, 12 Mar 2020 12:17:53 -0600 From: Tom Tromey To: Andrew Burgess Cc: gdb-patches@sourceware.org, richard.bunt@arm.com Subject: Re: [PATCH] gdb/testsuite/fortran: Add mixed language stack test References: <20200305210911.23478-1-andrew.burgess@embecosm.com> X-Attribution: Tom Date: Thu, 12 Mar 2020 12:17:52 -0600 In-Reply-To: <20200305210911.23478-1-andrew.burgess@embecosm.com> (Andrew Burgess's message of "Thu, 5 Mar 2020 21:09:11 +0000") Message-ID: <87d09hjv3j.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 184.96.250.69 X-Source-L: No X-Exim-ID: 1jCSP3-001hsu-LE X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 184-96-250-69.hlrn.qwest.net (murgatroyd) [184.96.250.69]:60540 X-Source-Auth: tom+tromey.com X-Email-Count: 4 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS, SPF_NEUTRAL autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Mar 2020 18:17:56 -0000 >>>>> "Andrew" == Andrew Burgess writes: Andrew> This commit adds a test that builds a mixed language stack, the stack Andrew> contains frames of Fortran, C, and C++. The test prints the backtrace Andrew> and explores the stack printing arguments of different types in frames Andrew> of different languages. Andrew> The core of the test is repeated with GDB's language set to auto, Andrew> fortran, c, and c++ in turn to ensure that GDB is happy to print Andrew> frames and frame arguments when the language is set to a value that Andrew> doesn't match the frame language. Andrew> This test currently passes, and there are no known bugs in this area. Andrew> The aim of this commit is simply to increase test coverage, as I don't Andrew> believe this functionality is currently tested. This seems like a good idea to me. The patch looked fine as well. Thank you for doing this. Tom