From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 46766 invoked by alias); 13 Feb 2019 21:05:59 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 46754 invoked by uid 89); 13 Feb 2019 21:05:59 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=jealous X-HELO: gateway36.websitewelcome.com Received: from gateway36.websitewelcome.com (HELO gateway36.websitewelcome.com) (192.185.194.2) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 13 Feb 2019 21:05:57 +0000 Received: from cm11.websitewelcome.com (cm11.websitewelcome.com [100.42.49.5]) by gateway36.websitewelcome.com (Postfix) with ESMTP id 11F9A400CAB07 for ; Wed, 13 Feb 2019 14:20:07 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id u1j8g2YfNdnCeu1j8g1UzO; Wed, 13 Feb 2019 15:05:54 -0600 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=PLBjt9cnuNlJ6/oaguBazcQSaeuAnFbSps2WqLWV2vA=; b=ZMhrOmMUOC/cd0dva6uEvMokGX uJoehMz8ncKf1Q8OHxqIp5NyFTjl/6E/es5D6a4/TLr6nKExXrdMT/xVJoL+6ko+7iNBgQy7xRdQc fUDoY+Fn1irN65bdRuyhnDti9; Received: from 75-166-72-210.hlrn.qwest.net ([75.166.72.210]:41944 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1gu1j8-001PIF-At; Wed, 13 Feb 2019 15:05:54 -0600 From: Tom Tromey To: Alan Hayward Cc: "gdb-patches\@sourceware.org" , nd Subject: Re: [PATCH/RFC] gdbserver: Add command line option to not use SO_REUSEADDR References: <20190212184827.91720-1-alan.hayward@arm.com> Date: Wed, 13 Feb 2019 21:05:00 -0000 In-Reply-To: <20190212184827.91720-1-alan.hayward@arm.com> (Alan Hayward's message of "Tue, 12 Feb 2019 18:48:35 +0000") Message-ID: <87d0nv5rgu.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2019-02/txt/msg00185.txt.bz2 >>>>> "Alan" == Alan Hayward writes: Alan> (Not sure if there is any additional documentation that will need Alan> updating alongside this patch, or any other additions that need Alan> to go alongside new command line flags). There is some documentation on invoking gdbserver in the manual, so that should be updated. Alan> Forcing on gdb and gdbserver debug shows that for the failure cases Alan> gdbserver is launched, connects to gdb and sucessfully sends and Alan> receives packets. Meanwhile on the gdb side, no packets are sent or Alan> received and the connection simply times out. This indicates that Alan> the gdb from another running test has connected to this gdbserver. Could you walk me through how this happens? It seems strange to me that there could be any kind of race. What I don't understand is that if two tests can run in parallel, both start gdbserver, and then one gdb can connect to the wrong server -- then it seems to me that the bug must be in the test suite itself? Alan> When running with -j55 on HEAD Jealous. Alan> 2019-02-12 Alan Hayward Alan> * remote-utils.c (remote_prepare): Check reuse flag. Alan> * server.c (gdbserver_usage): Add reuse help messages. Alan> (captured_main): Check for reuse flags Alan> * server.h (struct client_state): Add reuse flag. FWIW the contents of the patch all seem fine to me. But, I'd like to understand the problem better before approving it (and also there's the documentation). thanks, Tom