Re: [PATCH] Provide Solaris 11 buildbots

[Sergio Durigan Junior <sergiodj@redhat.com>]

On Friday, October 05 2018, Rainer Orth wrote:

> Hi Sergio,
>
>>>> I'll enable the email notifications for both builders later today.
>>>
>>> excellent, thanks.
>
> it would be great if you could do this: last night Tom's series of
> -Wshadow=local patches broke the Solaris build, which didn't trigger a
> gdb-patches mail, thus easily going unnoticed.

Hey Rainer,

Ops, sorry, I kind of forgot about this.  We've had face-to-face
meetings, and then I left on vacation.  It is enabled now.

>>> checking whether a statically linked program can dlopen itself... Setting
>>> warning flags = -W -Wall -Wstrict-prototypes -Wmissing-prototypes
>>> -Wshadow -Wstack-usage=262144 -Werror
>>> Setting warning flags = -W -Wall -Wstrict-prototypes -Wmissing-prototypes
>>> -Wshadow -Wstack-usage=262144 -Werror
>>> checking compiler warning flags...  -Wall -Wpointer-arith -Wno-unused
>>> -Wunused-value -Wunused-variable -Wunused-function -Wno-switch
>>> -Wno-char-subscripts -Wempty-body -Wunused-but-set-parameter
>>> -Wunused-but-set-variable -Wno-sign-compare
>>> -Wno-error=maybe-uninitialized -Wsuggest-override
>>> -Wimplicit-fallthrough=3 -Wduplicated-cond -Wno-unknown-pragmas
>>> -Wno-deprecated-declarations -Werror
>>>
>>> Those are all spurious, sometimes two different lines running into each
>>> other.
>>
>> This happens because of the parallel build.
>
> True, but even so the 'Setting warning flags' line counts as a warning ;-)

Ah, that's because of BuildBot's algorithm to detect warnings.  I
honestly never go to the "warnings" page because of that; I prefer
looking directly at the logs.  I don't know if BuildBot has improved its
warning detection in newer releases.

>>> /opt/gdb-buildbot/home/solaris11-sparcv9/solaris11-sparcv9-m64/build/gdb/../../binutils-gdb/gdb/c-exp.y:
>>> warning: 42 shift/reduce conflicts [-Wconflicts-sr]
>>> /opt/gdb-buildbot/home/solaris11-sparcv9/solaris11-sparcv9-m64/build/gdb/../../binutils-gdb/gdb/c-exp.y:
>>> warning: 53 reduce/reduce conflicts [-Wconflicts-rr]
>>> /opt/gdb-buildbot/home/solaris11-sparcv9/solaris11-sparcv9-m64/build/gdb/../../binutils-gdb/gdb/m2-exp.y:
>>> warning: 34 shift/reduce conflicts [-Wconflicts-sr]
>>> /opt/gdb-buildbot/home/solaris11-sparcv9/solaris11-sparcv9-m64/build/gdb/../../binutils-gdb/gdb/m2-exp.y:301.25-44:
>>> warning: rule useless in parser due to conflicts [-Wother]
>>>
>>> Those are from the bundled bison 3.0.4 and again also present on
>>> Fedora.  One could silence them with -Wno-conflicts-sr if need be, but
>>> that would require testing if the yacc/bison used supports those
>>> options.
>>>
>>> bison 2.4.2 only emits
>>>
>>> conflicts: 42 shift/reduce, 53 reduce/reduce
>>> conflicts: 34 shift/reduce
>>
>> They happen on pretty much every builder.  I personally don't think
>> these should be silenced.
>
> Probably not, though if the conflicts are as expected it would be nice
> they didn't trigger a warning.

Yeah.  I don't remember seeing a discussion about these conflicts; I
guess they've been ignored for a long time, now.

Thanks,

-- 
Sergio
GPG key ID: 237A 54B1 0287 28BF 00EF  31F4 D0EB 7628 65FC 5E36
Please send encrypted e-mail if possible
http://sergiodj.net/