From: Tom Tromey <tom@tromey.com>
To: Pedro Alves <palves@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 1/3] Avoid find_thread_ptid with null_ptid
Date: Mon, 01 Oct 2018 15:54:00 -0000 [thread overview]
Message-ID: <87d0stll3u.fsf@tromey.com> (raw)
In-Reply-To: <20181001103252.5150-2-palves@redhat.com> (Pedro Alves's message of "Mon, 1 Oct 2018 11:32:50 +0100")
>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:
Pedro> This patch prepares for the change, by avoiding passing down null_ptid
Pedro> to find_thread_ptid or to functions that naturally use it
Should find_thread_ptid assert this?
Pedro> if (print_inferior_events)
Pedro> - printf_unfiltered (_("[New inferior %d (%s)]\n"),
Pedro> - inf->num,
Pedro> - target_pid_to_str (ptid_t (pid)));
Pedro> + {
Pedro> + if (pid != 0)
Pedro> + printf_unfiltered (_("[New inferior %d (%s)]\n"),
Pedro> + inf->num,
Pedro> + target_pid_to_str (ptid_t (pid)));
Pedro> + else
Pedro> + printf_unfiltered (_("[New inferior %d]\n"), inf->num);
I wonder if it is possible for an RSP implementation to say that the
inferior has PID 0.
Tom
next prev parent reply other threads:[~2018-10-01 15:54 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-01 10:32 [PATCH 0/3] Per-inferior thread list, multi-target prep Pedro Alves
2018-10-01 10:32 ` [PATCH 1/3] Avoid find_thread_ptid with null_ptid Pedro Alves
2018-10-01 15:54 ` Tom Tromey [this message]
2018-10-02 17:08 ` Pedro Alves
2018-10-02 21:14 ` Tom Tromey
2018-10-01 10:33 ` [PATCH 2/3] Fix follow_exec latent problem Pedro Alves
2018-10-01 10:33 ` [PATCH 3/3] Per-inferior thread list, thread ranges/iterators, down with ALL_THREADS, etc Pedro Alves
2018-10-01 16:33 ` John Baldwin
2018-10-02 13:21 ` Pedro Alves
2018-10-03 17:34 ` John Baldwin
2018-10-04 19:16 ` Pedro Alves
2018-10-01 17:12 ` Tom Tromey
2018-10-03 12:12 ` Pedro Alves
2018-11-22 16:28 ` [PATCH 0/3] Per-inferior thread list, multi-target prep Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d0stll3u.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).