From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 90201 invoked by alias); 1 Oct 2018 15:54:08 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 90183 invoked by uid 89); 1 Oct 2018 15:54:07 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: gateway34.websitewelcome.com Received: from gateway34.websitewelcome.com (HELO gateway34.websitewelcome.com) (192.185.148.104) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 01 Oct 2018 15:54:05 +0000 Received: from cm10.websitewelcome.com (cm10.websitewelcome.com [100.42.49.4]) by gateway34.websitewelcome.com (Postfix) with ESMTP id AB03DA56742 for ; Mon, 1 Oct 2018 10:53:10 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id 70VSg6JtIBcCX70VSgRQw5; Mon, 01 Oct 2018 10:53:10 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=QOhyCCZFHVe21CIZuWnuMe0bjt6vhzL9/FqpbnrW3Nw=; b=f7RQUGrRx5eCH39S71nL687dez R3Tg2w0bv+zseFYn9mWzYgFVr2+nyCIEO9A5FDcBmTsOpQnzDqZmgETLW9Nmuimt7v8lA+UGgUkoG 45+UfN1ef7HBFeWCOqvAVJFXD; Received: from 97-122-190-66.hlrn.qwest.net ([97.122.190.66]:38588 helo=pokyo) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1g70VS-000ypu-8C; Mon, 01 Oct 2018 10:53:10 -0500 From: Tom Tromey To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 1/3] Avoid find_thread_ptid with null_ptid References: <20181001103252.5150-1-palves@redhat.com> <20181001103252.5150-2-palves@redhat.com> Date: Mon, 01 Oct 2018 15:54:00 -0000 In-Reply-To: <20181001103252.5150-2-palves@redhat.com> (Pedro Alves's message of "Mon, 1 Oct 2018 11:32:50 +0100") Message-ID: <87d0stll3u.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2018-10/txt/msg00019.txt.bz2 >>>>> "Pedro" == Pedro Alves writes: Pedro> This patch prepares for the change, by avoiding passing down null_ptid Pedro> to find_thread_ptid or to functions that naturally use it Should find_thread_ptid assert this? Pedro> if (print_inferior_events) Pedro> - printf_unfiltered (_("[New inferior %d (%s)]\n"), Pedro> - inf->num, Pedro> - target_pid_to_str (ptid_t (pid))); Pedro> + { Pedro> + if (pid != 0) Pedro> + printf_unfiltered (_("[New inferior %d (%s)]\n"), Pedro> + inf->num, Pedro> + target_pid_to_str (ptid_t (pid))); Pedro> + else Pedro> + printf_unfiltered (_("[New inferior %d]\n"), inf->num); I wonder if it is possible for an RSP implementation to say that the inferior has PID 0. Tom