From: Tom Tromey <tom@tromey.com>
To: Pedro Alves <palves@redhat.com>
Cc: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
Subject: Re: [RFA v2] Add "continue" response to pager
Date: Wed, 09 May 2018 21:28:00 -0000 [thread overview]
Message-ID: <87d0y44iyi.fsf@tromey.com> (raw)
In-Reply-To: <941985b1-5166-44ab-72fe-b0f62d411e2e@redhat.com> (Pedro Alves's message of "Wed, 9 May 2018 20:51:38 +0100")
>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:
Pedro> I gave the patch a quick try, and I have to say that it looks a
Pedro> bit odd to me that the pager prompt takes two lines:
Pedro> ---Type <return> to continue, q <return> to quit, or c <return> to
Pedro> continue without paging---
Pedro> I'm wondering whether we can shorten that, to, say:
Pedro> ---Type <return> for more, q to quit, c to continue without paging---
Yeah, I think that would be better.
The Emacs docs write <RET> for return. So maybe:
Pedro> --Type <ret> for more, q to quit, c to continue without paging-- # 64 cols
Though I guess I would tend to add a couple of spaces, so:
-- Type <RET> for more, q to quit, c to continue without paging -- # 66 cols
I would like to get the spelling worked out before updating the patch.
Pedro> Did you look up the patch submission, see if it still makes sense?
Nope, but if we shorten the text then perhaps the change won't be
needed.
>> +static int pagination_disabled_for_command;
Pedro> Use bool?
I made this change locally.
Tom
next prev parent reply other threads:[~2018-05-09 21:28 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-25 14:52 Tom Tromey
2018-05-09 15:43 ` Tom Tromey
2018-05-09 19:51 ` Pedro Alves
2018-05-09 21:28 ` Tom Tromey [this message]
2018-05-10 0:23 ` Pedro Alves
2018-05-27 15:20 ` Tom Tromey
2018-05-27 21:01 ` Eli Zaretskii
2018-05-28 18:57 ` Pedro Alves
2018-05-29 9:03 ` Tom Tromey
2018-05-29 17:04 ` Pedro Alves
2018-06-04 21:47 ` Tom Tromey
2018-06-05 14:44 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d0y44iyi.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).