From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 90226 invoked by alias); 9 May 2018 21:28:42 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 90216 invoked by uid 89); 9 May 2018 21:28:42 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.3 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=spelling X-HELO: gateway22.websitewelcome.com Received: from gateway22.websitewelcome.com (HELO gateway22.websitewelcome.com) (192.185.47.100) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 09 May 2018 21:28:40 +0000 Received: from cm16.websitewelcome.com (cm16.websitewelcome.com [100.42.49.19]) by gateway22.websitewelcome.com (Postfix) with ESMTP id D2BC168AC for ; Wed, 9 May 2018 16:28:38 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id GWdaf4WS0WCOCGWdafwYVG; Wed, 09 May 2018 16:28:38 -0500 X-Authority-Reason: nr=8 Received: from 97-122-176-117.hlrn.qwest.net ([97.122.176.117]:34458 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89_1) (envelope-from ) id 1fGWda-001Rpx-IW; Wed, 09 May 2018 16:28:38 -0500 From: Tom Tromey To: Pedro Alves Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [RFA v2] Add "continue" response to pager References: <20180425145200.27734-1-tom@tromey.com> <941985b1-5166-44ab-72fe-b0f62d411e2e@redhat.com> Date: Wed, 09 May 2018 21:28:00 -0000 In-Reply-To: <941985b1-5166-44ab-72fe-b0f62d411e2e@redhat.com> (Pedro Alves's message of "Wed, 9 May 2018 20:51:38 +0100") Message-ID: <87d0y44iyi.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BWhitelist: no X-Source-L: No X-Exim-ID: 1fGWda-001Rpx-IW X-Source-Sender: 97-122-176-117.hlrn.qwest.net (bapiya) [97.122.176.117]:34458 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-SW-Source: 2018-05/txt/msg00222.txt.bz2 >>>>> "Pedro" == Pedro Alves writes: Pedro> I gave the patch a quick try, and I have to say that it looks a Pedro> bit odd to me that the pager prompt takes two lines: Pedro> ---Type to continue, q to quit, or c to Pedro> continue without paging--- Pedro> I'm wondering whether we can shorten that, to, say: Pedro> ---Type for more, q to quit, c to continue without paging--- Yeah, I think that would be better. The Emacs docs write for return. So maybe: Pedro> --Type for more, q to quit, c to continue without paging-- # 64 cols Though I guess I would tend to add a couple of spaces, so: -- Type for more, q to quit, c to continue without paging -- # 66 cols I would like to get the spelling worked out before updating the patch. Pedro> Did you look up the patch submission, see if it still makes sense? Nope, but if we shorten the text then perhaps the change won't be needed. >> +static int pagination_disabled_for_command; Pedro> Use bool? I made this change locally. Tom