From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 91892 invoked by alias); 16 Oct 2017 15:54:09 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 91874 invoked by uid 89); 16 Oct 2017 15:54:08 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=letter X-HELO: gproxy4-pub.mail.unifiedlayer.com Received: from gproxy4-pub.mail.unifiedlayer.com (HELO gproxy4-pub.mail.unifiedlayer.com) (69.89.23.142) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 16 Oct 2017 15:54:07 +0000 Received: from cmgw2 (unknown [10.0.90.83]) by gproxy4.mail.unifiedlayer.com (Postfix) with ESMTP id 0CA21175E6B for ; Mon, 16 Oct 2017 09:54:06 -0600 (MDT) Received: from box522.bluehost.com ([74.220.219.122]) by cmgw2 with id NFu21w01F2f2jeq01Fu5yt; Mon, 16 Oct 2017 09:54:06 -0600 X-Authority-Analysis: v=2.2 cv=dZfw5Tfe c=1 sm=1 tr=0 a=GsOEXm/OWkKvwdLVJsfwcA==:117 a=GsOEXm/OWkKvwdLVJsfwcA==:17 a=02M-m0pO-4AA:10 a=pGLkceISAAAA:8 a=zstS-IiYAAAA:8 a=2PkX_KINZOKoGrC1ydYA:9 a=S_HVFEA2qnQA:10 a=4G6NA9xxw8l3yy4pmD5M:22 Received: from 184-96-33-178.hlrn.qwest.net ([184.96.33.178]:44860 helo=bapiya) by box522.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.87) (envelope-from ) id 1e47iM-002JKO-Ha; Mon, 16 Oct 2017 09:54:02 -0600 From: Tom Tromey To: Yao Qi Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [RFA 1/8] Constify add_abbrev_prefix_cmd References: <20171013205950.22943-1-tom@tromey.com> <20171013205950.22943-2-tom@tromey.com> <8660bfxy7z.fsf@gmail.com> Date: Mon, 16 Oct 2017 15:54:00 -0000 In-Reply-To: <8660bfxy7z.fsf@gmail.com> (Yao Qi's message of "Mon, 16 Oct 2017 10:01:52 +0100") Message-ID: <87d15nt7fq.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.60 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BWhitelist: no X-Exim-ID: 1e47iM-002JKO-Ha X-Source-Sender: 184-96-33-178.hlrn.qwest.net (bapiya) [184.96.33.178]:44860 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTIyLmJsdWVob3N0LmNvbQ== X-Local-Domain: yes X-SW-Source: 2017-10/txt/msg00448.txt.bz2 >>>>> "Yao" == Yao Qi writes: Yao> Tom Tromey writes: >> This changes add_abbrev_prefix_cmd to take a const-taking callback >> function and then fixes the one caller. >> >> gdb/ChangeLog >> 2017-10-13 Tom Tromey >> >> * breakpoint.c (stop_command): Constify. >> * cli/cli-decode.c (struct cmd_list_element): Constify. >> * command.h (add_abbrev_prefix_cmd): Constify. Yao> As you said in cover letter, breakpoint.c:stop_command needs update as Yao> well. You can pull the stop_command change in this patch, and it looks Yao> good to me. I'm sorry -- I don't understand what I ought to do here. I think this patch does include a change to stop_command. Tom