From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 96972 invoked by alias); 14 Jun 2017 19:49:20 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 96098 invoked by uid 89); 14 Jun 2017 19:49:19 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 14 Jun 2017 19:49:18 +0000 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 1906D4DD4B; Wed, 14 Jun 2017 19:49:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 1906D4DD4B Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=sergiodj@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 1906D4DD4B Received: from localhost (unused-10-15-17-193.yyz.redhat.com [10.15.17.193]) by smtp.corp.redhat.com (Postfix) with ESMTPS id DAE774DA0B; Wed, 14 Jun 2017 19:49:21 +0000 (UTC) From: Sergio Durigan Junior To: Simon Marchi Cc: Subject: Re: [PATCH 5/5] Add ATTRIBUTE_PRINTF to trace_start_error References: <1497124689-11842-1-git-send-email-simon.marchi@ericsson.com> <1497124689-11842-6-git-send-email-simon.marchi@ericsson.com> X-URL: https://sergiodj.net Date: Wed, 14 Jun 2017 19:49:00 -0000 In-Reply-To: <1497124689-11842-6-git-send-email-simon.marchi@ericsson.com> (Simon Marchi's message of "Sat, 10 Jun 2017 21:58:09 +0200") Message-ID: <87d1a6cptq.fsf@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2017-06/txt/msg00438.txt.bz2 On Saturday, June 10 2017, Simon Marchi wrote: > clang complains that the fmt passed to vwarning in trace_start_error is > not a literal. This looks like a fair warning, which can be removed by > adding ATTRIBUTE_PRINTF to the declaration of trace_start_error. > > gdb/ChangeLog: > > * nat/fork-inferior.h (trace_start_error): Add ATTRIBUTE_PRINTF. > --- > gdb/nat/fork-inferior.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/gdb/nat/fork-inferior.h b/gdb/nat/fork-inferior.h > index 10e3832..d369cff 100644 > --- a/gdb/nat/fork-inferior.h > +++ b/gdb/nat/fork-inferior.h > @@ -95,7 +95,7 @@ extern void gdb_flush_out_err (); > (i.e., when the "traceme_fun" callback is called on fork_inferior) > and bail out. This function does not return. */ > extern void trace_start_error (const char *fmt, ...) > - ATTRIBUTE_NORETURN; > + ATTRIBUTE_NORETURN ATTRIBUTE_PRINTF (1, 2); > > /* Like "trace_start_error", but the error message is constructed by > combining STRING with the system error message for errno. This > -- > 2.7.4 Thanks, this looks good to me. -- Sergio GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36 Please send encrypted e-mail if possible http://sergiodj.net/