From: Sergio Durigan Junior <sergiodj@redhat.com>
To: Patrick Palka <patrick@parcs.ath.cx>
Cc: Doug Evans <xdje42@gmail.com>, Doug Evans <dje@google.com>,
"gdb-patches\@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [PATCH 5/8] gen-pert-test: parallel build support
Date: Sat, 25 Jul 2015 23:21:00 -0000 [thread overview]
Message-ID: <87d1zf4ye3.fsf@redhat.com> (raw)
In-Reply-To: <CA+C-WL-Uuhw646D6u3KgLoS_-VJLVemEvYfjjhBWjstoAvAPuQ@mail.gmail.com> (Patrick Palka's message of "Sat, 25 Jul 2015 14:39:01 -0400")
On Saturday, July 25 2015, Patrick Palka wrote:
>>> This patch seems to have caused a number of regressions:
>>>
>>> http://gdb-build.sergiodj.net/builders/Fedora-x86_64-m64/builds/1502
>>> http://gdb-build.sergiodj.net/builders/Fedora-x86_64-m32/builds/1501
>>> http://gdb-build.sergiodj.net/builders/Fedora-i686/builds/1510
>>>
>>> (possibly among others)
>>>
>>> Reverting this patch locally makes the regressions disappear for me,
>>> at least on x86_64-m64.
>>
>> I can't repro this.
>> It's odd that this patch would cause these particular regressions:
>>
>> http://gdb-build.sergiodj.net/builders/Fedora-x86_64-m32/builds/1501/steps/regressions/logs/regressions
>>
>> http://gdb-build.sergiodj.net/builders/Fedora-x86_64-m64/builds/1502/steps/regressions/logs/regressions
>>
>> Also, I don't understand this one:
>>
>> http://gdb-build.sergiodj.net/builders/Debian-x86_64-m64/builds/1420
>>
>> I can imagine makefile hacking for the perf tests breaking normal make check,
>> but then I'd expect the damage to be far more extensive, but the patch
>> reported in 1420 cannot have caused those regressions.
>
> In this case, the regressions listed for build 1420 originated from build 1417:
>
> http://gdb-build.sergiodj.net/builders/Debian-x86_64-m64/builds/1417
>
> The baseline for checking for regressions is not the build before, but
> rather it's a "rolling" baseline or something like that.
Sorry, as it turns out I found a bug in the way BuildBot calculated the
regressions for the current build. Unfortunately it wasn't correctly
updating the previous_gdb.sum file, which is used to directly calculate
the regressions against the last build. The bug has been fixed now; it
has been introduced a few days ago, so not many builds have been
compromised. Also, the regressions reported *were* valid; the only
problem was that they were being reported over and over for every build.
--
Sergio
GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36
Please send encrypted e-mail if possible
http://sergiodj.net/
next prev parent reply other threads:[~2015-07-25 23:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-21 13:44 Doug Evans
2015-07-25 16:44 ` Patrick Palka
2015-07-25 18:25 ` Doug Evans
2015-07-25 18:39 ` Patrick Palka
2015-07-25 23:21 ` Sergio Durigan Junior [this message]
2015-07-25 18:59 ` Doug Evans
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d1zf4ye3.fsf@redhat.com \
--to=sergiodj@redhat.com \
--cc=dje@google.com \
--cc=gdb-patches@sourceware.org \
--cc=patrick@parcs.ath.cx \
--cc=xdje42@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).