Re: [PING] [PATCH] Fix gdb.fortran/array-element.exp failures.

[Gabriel Krisman Bertazi <gabriel@krisman.be>]

[-- Attachment #1: Type: text/plain, Size: 1087 bytes --]

Joel,

> To help us out, it's useful to show what the patch does in practice.
> In this case, I'd like to do what's not working before the patch
> gets applied, and how things change once your patch is applied.
> GDB transcripts before and after usually help with that.

Sorry I didn't resend the original message with my pings.  Here it goes.

This fixes two FAIL results when running this test file due to a
misplaced "continue" command, which caused the inferior to end execution
prematurely.

On trunk, we have:

FAIL: gdb.fortran/array-element.exp: continue to breakpoint once again
(the program exited)
FAIL: gdb.fortran/array-element.exp: print the second element of array a

                === gdb Summary ===

                # of expected passes            3
                # of unexpected failures        2

And now, we get:
                === gdb Summary ===
                # of expected passes            3

Is this ok?

2014-07-04  Gabriel Krisman Bertazi  <gabriel@krisman.be>

	* gdb.fortran/array-element.exp: Remove wrong "continue"
	command.  Simplify test case.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: fortran_patch.patch --]
[-- Type: text/x-patch, Size: 974 bytes --]

diff --git a/gdb/testsuite/gdb.fortran/array-element.exp b/gdb/testsuite/gdb.fortran/array-element.exp
index 579db03..1ac3623 100644
--- a/gdb/testsuite/gdb.fortran/array-element.exp
+++ b/gdb/testsuite/gdb.fortran/array-element.exp
@@ -31,18 +31,9 @@ if ![runto sub_] then {
     continue
 }
 
-set bp_location [gdb_get_line_number "continue"]
-gdb_test "break $bp_location" \
-    "Breakpoint.*at.* file .*$srcfile, line $bp_location\\." \
-    "breakpoint at continue"
-
-gdb_test "continue" \
-    "Continuing\\..*Breakpoint.*" \
-    "continue to breakpoint"
-gdb_test "print a(1)" ".*1 = 1.*" "print the first element of array a"
+gdb_breakpoint [gdb_get_line_number "continue"]
+gdb_continue_to_breakpoint "continue"
 
-gdb_test "continue" \
-    "Continuing\\..*Breakpoint.*" \
-    "continue to breakpoint once again"
+gdb_test "print a(1)" ".*1 = 1.*" "print the first element of array a"
 gdb_test "print a(2)" ".*2 = 2.*" "print the second element of array a"
 

[-- Attachment #3: Type: text/plain, Size: 29 bytes --]


-- 
Gabriel Krisman Bertazi