From: Tom Tromey <tromey@redhat.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [patch] Fix TLS access for -static -pthread
Date: Tue, 20 May 2014 15:10:00 -0000 [thread overview]
Message-ID: <87d2f8trjo.fsf@fleche.redhat.com> (raw)
In-Reply-To: <20140410115204.GB16411@host2.jankratochvil.net> (Jan Kratochvil's message of "Thu, 10 Apr 2014 13:52:04 +0200")
>>>>> "Jan" == Jan Kratochvil <jan.kratochvil@redhat.com> writes:
Jan> I have posted:
Jan> TLS variables access for -static -lpthread executables
Jan> https://sourceware.org/ml/libc-help/2014-03/msg00024.html
Jan> and the GDB patch below has been confirmed as OK for current glibcs.
Jan> + /* GNU __libc_setup_tls initializes l_tls_modid as 1. */
Jan> + err = info->td_thr_tlsbase_p (&thread_info->private->th,
Jan> + 1, &address);
This bit of code (and another like it later on) should have a longer
comment, probably at least including the link above, but also some text
about how this is a hack but why it is ok.
Otherwise this is ok.
Tom
next prev parent reply other threads:[~2014-05-20 15:10 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-10 11:52 Jan Kratochvil
2014-04-11 11:03 ` Jan Kratochvil
2014-05-20 15:10 ` Tom Tromey
2014-05-20 15:18 ` Jan Kratochvil
2014-05-20 15:10 ` Tom Tromey [this message]
2014-05-21 12:17 ` Jan Kratochvil
2014-05-21 14:14 ` Tom Tromey
2014-05-21 14:28 ` [commit] " Jan Kratochvil
2014-06-05 7:17 ` Yao Qi
2014-06-05 8:06 ` Jan Kratochvil
2014-06-05 9:32 ` Yao Qi
2014-06-05 9:39 ` Jan Kratochvil
2014-06-05 14:20 ` Yao Qi
2014-06-05 15:23 ` Pedro Alves
2014-06-06 2:26 ` Yao Qi
2014-06-05 15:18 ` Pedro Alves
2014-06-06 15:03 ` Jan Kratochvil
2014-06-06 2:36 ` Yao Qi
2014-06-06 6:16 ` Yao Qi
2014-06-06 14:20 ` Jan Kratochvil
2014-06-06 5:34 ` Sergio Durigan Junior
2014-06-06 14:21 ` Jan Kratochvil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d2f8trjo.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).