public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Ulrich Weigand <Ulrich.Weigand@de.ibm.com>
To: "akamath996@gmail.com" <akamath996@gmail.com>,
	"tom@tromey.com" <tom@tromey.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>,
	Aditya Kamath1 <Aditya.Kamath1@ibm.com>,
	Sangamesh Mallayya <sangamesh.swamy@in.ibm.com>,
	"jhb@freebsd.org" <jhb@freebsd.org>
Subject: Re: [PATCH v4] Fix AIX thread exit events not being reported and UI to show  kernel thread ID.
Date: Fri, 3 May 2024 14:45:04 +0000	[thread overview]
Message-ID: <87d9aaba7a4df18e5ae1aba86092cf50de42c230.camel@de.ibm.com> (raw)
In-Reply-To: <20240503142610.27676-1-akamath996@gmail.com>

Aditya Vidyadhar Kamath <akamath996@gmail.com> wrote:

>+	  if (get_signaled_thread (pid) == tid
>+		&& in_thread_list (proc_target, ptid_t (pid)))
Didn't you want to change this?

>+	auto itr = in_queue_threads.find (priv->pdtid);
>+	if (itr == in_queue_threads.end ()
Why don't you use .count like elsewhere?

Otherwise this looks good to me now.

Thanks,
Ulrich


      parent reply	other threads:[~2024-05-03 14:45 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-03 14:26 Aditya Vidyadhar Kamath
2024-05-03 14:34 ` Aditya Kamath1
2024-05-03 14:45 ` Ulrich Weigand [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87d9aaba7a4df18e5ae1aba86092cf50de42c230.camel@de.ibm.com \
    --to=ulrich.weigand@de.ibm.com \
    --cc=Aditya.Kamath1@ibm.com \
    --cc=akamath996@gmail.com \
    --cc=gdb-patches@sourceware.org \
    --cc=jhb@freebsd.org \
    --cc=sangamesh.swamy@in.ibm.com \
    --cc=tom@tromey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).