From: Tom Tromey <tom@tromey.com>
To: Andrew Burgess <aburgess@redhat.com>
Cc: Joel Brobecker <brobecker@adacore.com>,
Simon Marchi <simark@simark.ca>, Eli Zaretskii <eliz@gnu.org>,
gdb-patches@sourceware.org
Subject: Re: [PATCH] gdb/doc: use silent-rules.mk in the Makefile
Date: Tue, 28 May 2024 09:25:15 -0600 [thread overview]
Message-ID: <87ed9mrmas.fsf@tromey.com> (raw)
In-Reply-To: <87zfsc9o4k.fsf@redhat.com> (Andrew Burgess's message of "Sun, 26 May 2024 23:58:35 +0100")
>>>>> "Andrew" == Andrew Burgess <aburgess@redhat.com> writes:
Andrew> Anyway, let me know what you think.
FWIW this looks good to me.
Approved-By: Tom Tromey <tom@tromey.com>
Andrew> One possibly weird thing here is that I have left both an
Andrew> ECHO_TEXI2POD and a ECHO_TEXI2MAN in the rule $(MAN1S) and $(MAN5S)
Andrew> recipes. This is 100% not going to break anything, these just print
Andrew> two different progress messages while executing the recipes, but I'm
Andrew> not sure if this is considered poor style or not. Maybe we're only
Andrew> supposed to have a single ECHO_* per recipe?
I don't feel strongly about this either way.
Tom
next prev parent reply other threads:[~2024-05-28 15:25 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-12 17:00 Andrew Burgess
2024-04-12 18:31 ` Eli Zaretskii
2024-04-12 22:32 ` Andrew Burgess
2024-04-13 7:02 ` Eli Zaretskii
2024-04-15 13:55 ` Andrew Burgess
2024-04-15 14:18 ` Simon Marchi
2024-04-16 7:48 ` Andrew Burgess
2024-04-16 8:47 ` Andrew Burgess
2024-04-16 15:01 ` Simon Marchi
2024-04-17 21:00 ` Andrew Burgess
2024-05-08 17:46 ` Andrew Burgess
2024-05-26 18:20 ` Joel Brobecker
2024-05-26 22:02 ` Andrew Burgess
2024-05-26 22:58 ` Andrew Burgess
2024-05-28 15:25 ` Tom Tromey [this message]
2024-04-15 14:37 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ed9mrmas.fsf@tromey.com \
--to=tom@tromey.com \
--cc=aburgess@redhat.com \
--cc=brobecker@adacore.com \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=simark@simark.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).