From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from omta040.useast.a.cloudfilter.net (omta040.useast.a.cloudfilter.net [44.202.169.39]) by sourceware.org (Postfix) with ESMTPS id E067D3849ACF for ; Fri, 19 Apr 2024 18:50:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E067D3849ACF Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org E067D3849ACF Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=44.202.169.39 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713552657; cv=none; b=V7/sFtwqRjcX239GXyOfrPkgR79951S35aOkEHMmKAPrGNQLhraBOOvMgQOpN390q+Ha6XjetNJe9dTIZqr+dCJzcy9AE1bDiM+RQM8f7i5ylcTvuk8b6QulEE/5OALmsAufUE2o0TfFjuKh29+qZ0FmrMOLq1tjlZ4wYIwJ+yY= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713552657; c=relaxed/simple; bh=ptt4HTbAwCehhIPtTdSSp9kUzXSlRphHNop32VZdRGE=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=vDvD0/NJoCJCTbRX1E9TEY3HvTwJ0v86g0/m1s0a7qk4Xc8eMzqKH5hUVaOcRW3qnuemKaJwSpQaS81bXdl7ozYgjkRKhp8Z2uC1LksPTV/gkokn2/fo/TkG9m393Hm6JAM0cVIyFXE3NKdLu9ohqx2/V252gXiC2MO7PKDjIpU= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from eig-obgw-6003a.ext.cloudfilter.net ([10.0.30.151]) by cmsmtp with ESMTPS id xhw3rVlJfl9dRxtK3raLXB; Fri, 19 Apr 2024 18:50:55 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id xtK2r5R5hd4oextK2rBIrZ; Fri, 19 Apr 2024 18:50:54 +0000 X-Authority-Analysis: v=2.4 cv=aYKqngot c=1 sm=1 tr=0 ts=6622bd0e a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=raytVjVEu-sA:10 a=Qbun_eYptAEA:10 a=T_Alst9gAAAA:8 a=zstS-IiYAAAA:8 a=FQPcC4AhVD6cDto1LY0A:9 a=DvZ5ixILWSEuw56YIEpp:22 a=4G6NA9xxw8l3yy4pmD5M:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=ptt4HTbAwCehhIPtTdSSp9kUzXSlRphHNop32VZdRGE=; b=QtKdHmpBrPUKAiKixYzjPG78kZ HmIeacsNlxraglQgbUirvJTjpbOVINb1DJi8YLCzURI7mBlmJsKwlYe4S4hdK0NTLFx/vi/IbKRA2 V3uaRvRQAyw2yAe0nJB3gn+v3; Received: from 97-122-86-252.hlrn.qwest.net ([97.122.86.252]:44946 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96.2) (envelope-from ) id 1rxtK2-003CqM-0u; Fri, 19 Apr 2024 12:50:54 -0600 From: Tom Tromey To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 09/12] gdb_target_is_native -> gdb_protocol_is_native References: <20240419151342.1592474-1-pedro@palves.net> <20240419151342.1592474-10-pedro@palves.net> X-Attribution: Tom Date: Fri, 19 Apr 2024 12:50:53 -0600 In-Reply-To: <20240419151342.1592474-10-pedro@palves.net> (Pedro Alves's message of "Fri, 19 Apr 2024 16:13:39 +0100") Message-ID: <87edb1w5iq.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.86.252 X-Source-L: No X-Exim-ID: 1rxtK2-003CqM-0u X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-86-252.hlrn.qwest.net (murgatroyd) [97.122.86.252]:44946 X-Source-Auth: tom+tromey.com X-Email-Count: 12 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfPeV5U6bxV9gOUO+iHZqcE3KRQTuNZfud0Ra+7RdkOqEOg0ZIUdgYlD5xkPO3iB2hIMUWwsyy33wWutb9SRF4XY4DsrUZg1QsegitRL8b4uK2GgqbJVa +aDwwTZfhV9v8AkqNxD2BHg0AlUMsHZFkTxJUebw3LtJs1FgOS+wiJkALwDr2DES5aYm6+VT2tWYUQ8ssXFQoYxRYLvaAc/XpCI= X-Spam-Status: No, score=-3015.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Pedro" == Pedro Alves writes: Pedro> gdb_is_target_native uses "maint print target-stack", which is Pedro> unnecessary when checking whether gdb_protocol is empty would do. Pedro> Checking gdb_protocol is more efficient, and can be done before Pedro> starting GDB and running to main, unlike gdb_is_target_native. Pedro> This adds a new gdb_protocol_is_native procedure, and uses it in place Pedro> of gdb_is_target_native. Pedro> At first, I thought that we'd end up with a few testcases needing to Pedro> use gdb_is_target_native still, especially multi-target tests that Pedro> connect to targets different from the default board target, but no, Pedro> actually all uses of gdb_is_target_native could be converted. Pedro> gdb_is_target_native will be eliminated in a following patch. Pedro> In some spots, we no longer need to defer the check until after Pedro> starting GDB, so the patch adjusts accordingly. Seems reasonable to me. Approved-By: Tom Tromey Tom