From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from omta038.useast.a.cloudfilter.net (omta038.useast.a.cloudfilter.net [44.202.169.37]) by sourceware.org (Postfix) with ESMTPS id 1AB3B3858C98 for ; Wed, 20 Mar 2024 17:17:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1AB3B3858C98 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 1AB3B3858C98 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=44.202.169.37 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710955046; cv=none; b=UU5y+KF3OYIa8UmDzzxDSrHdyP/P0q7j/mZzqxe4FS432cKHpMsvrW+Wi9bpwjavv87kq8S+2NaH2bS7UrL+dYnfsz3QKQNHczxB52hivnX86Os7LrrewBA2PR3z9G9YU3DQAe9Jpn2xPwtuT8j6WZbSqMKKZSrnqdoZorXU3YI= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710955046; c=relaxed/simple; bh=COWU3vwp4x2MaeRbhB2zoQUvcqQoUOiQj2Xg4966Shg=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=OmPniEqM9ROLyIwh4DXh0MF3h04KtF2tiveCDOeSQFoOAHdyBC31AqCP/YUtSQahSXV1A6h7Z61SULeCho8ibOWQcfCQ9DY9ujFmGBjAP2HuGw56ehynEPsc+aTckepV+kOn7v7JWeRZDxDQ6C2CD9HAlGzdr3Djx7+R8eGnzgo= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from eig-obgw-5002a.ext.cloudfilter.net ([10.0.29.215]) by cmsmtp with ESMTPS id mRcgrCa9iQr4SmzZ5rVSEw; Wed, 20 Mar 2024 17:17:23 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id mzZ4rBzzzybtzmzZ5raa2J; Wed, 20 Mar 2024 17:17:23 +0000 X-Authority-Analysis: v=2.4 cv=RsAOLzmK c=1 sm=1 tr=0 ts=65fb1a23 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=K6JAEmCyrfEA:10 a=Qbun_eYptAEA:10 a=zstS-IiYAAAA:8 a=plx3_TY8El4YMGmMhrEA:9 a=4G6NA9xxw8l3yy4pmD5M:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=COWU3vwp4x2MaeRbhB2zoQUvcqQoUOiQj2Xg4966Shg=; b=km3MD1GnK7/cJH2vWs/dxMuk5j WHzgmTylnXrlnalTiktRE73A3f++2CqZj8nHrb+CKmf0sZBpvk1k5ZxCcq6egRiBLf1AGVju1nB/x ng+GNmC6xIQoQ1oJV1NIL3JUC; Received: from 97-122-82-115.hlrn.qwest.net ([97.122.82.115]:33842 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96.2) (envelope-from ) id 1rmzZ4-001HpL-1f; Wed, 20 Mar 2024 11:17:22 -0600 From: Tom Tromey To: Tom de Vries Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] [gdb/testsuite] Handle core without build-id in gdb.base/corefile-buildid.exp References: <20240319073812.18995-1-tdevries@suse.de> X-Attribution: Tom Date: Wed, 20 Mar 2024 11:17:21 -0600 In-Reply-To: <20240319073812.18995-1-tdevries@suse.de> (Tom de Vries's message of "Tue, 19 Mar 2024 08:38:12 +0100") Message-ID: <87edc4g6vy.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.82.115 X-Source-L: No X-Exim-ID: 1rmzZ4-001HpL-1f X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-82-115.hlrn.qwest.net (murgatroyd) [97.122.82.115]:33842 X-Source-Auth: tom+tromey.com X-Email-Count: 6 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfPTYM03irb+mMrmaZvazK42uPIlj2wmD9S8R4nNhVUnBrERypJhiSS6AOI5NYQLsi/j4IB0V9l6fWEVpNB9aJGdSVCXDyRaGMAUpyq2EG8SjAaSj0LCz PP5MkT4CFmhx5kSgkE+dJf4CuvRJKh0Ms68DWu9mhFkbj2NEXBQ6fn1X0LVi4PUESZtx8lChEU2xcOhzjd3oUZiq9fv4RAopXJo= X-Spam-Status: No, score=-3015.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Tom" == Tom de Vries writes: Tom> The problem is that the test-case expect the build-id to be available in the Tom> core file, while it isn't. Tom> Fix this by detecting that the build-id isn't available in the core file using eu-readelf, as in Tom> gdb.base/coredump-filter-build-id.exp. I was kind of surprised to find that gdb's test suite depends on a non-binutils program like this, but whatever, the dependency is already there. Anyway this seems fine to me. Approved-By: Tom Tromey Tom