From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from omta034.useast.a.cloudfilter.net (omta034.useast.a.cloudfilter.net [44.202.169.33]) by sourceware.org (Postfix) with ESMTPS id 7AF5F3858D37 for ; Mon, 18 Mar 2024 16:26:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7AF5F3858D37 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 7AF5F3858D37 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=44.202.169.33 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710779194; cv=none; b=GVfujtompXtDY3FduMoNSzSSgldN2h8hdj8H82n3RO8HWCNHBuhfKix+NRyKp/2u3/XHBu4cvIHSnpcwu85k/gNwNogRGF7HE4v6EWF77GJPFOzpFODLDPh1iW18GltZxOSdqeUMmmUkuLqHWP249TaIq7/W+8KrpKuYtfoK2R0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710779194; c=relaxed/simple; bh=nklewkzIlGTWnPDEr+ycymhVzvyrueYWyd5NhV7uiGo=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=NP0LaZxl8NEQQani2Y7P3i941ZXrPsQ2173t17OZkspc54RrwdgxcQF0T3KWN6MD+7wjfqCrt58VZo9oyJbF898mYMMpGV6exr0boJ2Gz7eCtDfgyktv3SJyCGlo0yI4rAAmjtiT4Xbi1PuyMe4unSbj6BF7Fm5CY86iVkFLLe8= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from eig-obgw-6004a.ext.cloudfilter.net ([10.0.30.197]) by cmsmtp with ESMTPS id mCo8rYSBJs4yTmFomrZafU; Mon, 18 Mar 2024 16:26:33 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id mFomrSj047QepmFomr3N96; Mon, 18 Mar 2024 16:26:32 +0000 X-Authority-Analysis: v=2.4 cv=CMAsXwrD c=1 sm=1 tr=0 ts=65f86b38 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=K6JAEmCyrfEA:10 a=Qbun_eYptAEA:10 a=20KFwNOVAAAA:8 a=HRL8t-SqihBt1yjrBCoA:9 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=W0r5OVRT5RUZ4eFFcHsh8Oj3QxZ8RvC77ebvsUlV5XI=; b=ysjD4/kSKNrsRqZUGIVg9a1O0V ZIobwckE9610cQGhdQHgQgbdpY0wCnfiy0xuLPJY3n297ofILNQXfSd/JOo8cDQrW/Pkd+ay4VzX8 xg3G6JJ6/60vw8lZYrHsFxAOh; Received: from 97-122-82-115.hlrn.qwest.net ([97.122.82.115]:51546 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96.2) (envelope-from ) id 1rmFol-002kDy-2K; Mon, 18 Mar 2024 10:26:31 -0600 From: Tom Tromey To: Guinevere Larsen Cc: Hannes Domani , gdb-patches@sourceware.org, Keith Seitz Subject: Re: [PATCH] Fix comparison of array types References: <20240209194545.31497-1-ssbssa.ref@yahoo.de> <20240209194545.31497-1-ssbssa@yahoo.de> <4b9a274e-f072-4408-b797-857573a96b11@redhat.com> X-Attribution: Tom Date: Mon, 18 Mar 2024 10:26:29 -0600 In-Reply-To: <4b9a274e-f072-4408-b797-857573a96b11@redhat.com> (Guinevere Larsen's message of "Thu, 29 Feb 2024 14:26:07 +0100") Message-ID: <87edc7ik0a.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.82.115 X-Source-L: No X-Exim-ID: 1rmFol-002kDy-2K X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-82-115.hlrn.qwest.net (murgatroyd) [97.122.82.115]:51546 X-Source-Auth: tom+tromey.com X-Email-Count: 6 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfKKyUC0KeoBDRr7pNBWmfeUJma6mLM76EeycxOP+8SuUbMM0aqiaSKKGcwfWNM3KCv50dxK47X5bfV8R6kxQdOdZF25vt7xae0I+b0S+G6Vll6Ig4kGh BZcJ8z/wEWZtMi5cRvyjbJUJiuyrqzitiodCpCVfMdWB8bodzNVvFx2QnkypaoEmuX0/uutQGk56evzWBHYOhb3+5lBSb/NQkEs= X-Spam-Status: No, score=-3015.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> Guinevere Larsen writes: > My one nitpick is that I think this code fits more naturally right > after the pointer check, instead of the last check in the function, > but feel free to disagree. Either way: Reviewed-By: Guinevere Larsen > This would make sense too, but I'm not sure how much it matters. In most languages, array types don't have a name anyway. Also I wonder if we really want to keep all these different type-equality functions around. Right now there is types_equal, types_deeply_equal, and also ada_type_match. The Ada one is maybe hard to remove as long as GNAT encodings are relevant. However maybe we could replace types_equal with types_deeply_equal everywhere. Tom